From: Jens Axboe <axboe@kernel.dk>
To: Tal Zussman <tz2294@columbia.edu>, Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Hannes Reinecke <hare@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
John Garry <john.garry@linux.dev>,
Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Keith Busch <kbusch@kernel.org>,
"Martin K. Petersen" <mkp@kernel.org>
Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH v5 0/9] block device fixes for large block sizes, IOCB_NOWAIT, and direct I/O
Date: Wed, 7 Oct 2026 08:05:23 -0600 [thread overview]
Message-ID: <960b1305-c5a6-4554-8bab-1cf4244fa11b@kernel.dk> (raw)
In-Reply-To: <20260923-blkdev-fixes-v5-0-89e60d66eb38@columbia.edu>
On 9/23/26 5:56 PM, Tal Zussman wrote:
> A set of independent fixes for the block device file operations. The
> first two were found by Sashiko while reviewing the RWF_DONTCACHE series
> [1]. The fourth and fifth were found by Sashiko's review of v1 of this
> series, and the rest came from asking an LLM to find any similar or
> related issues. Each issue has been reproduced, with the fixes resolving
> the issues.
>
> Patch 1 fixes silently lost mmap writes with CONFIG_BUFFER_HEAD=n.
>
> Patches 2 and 3 take i_rwsem around the direct I/O write fallback and
> the splice read path, which race set_blocksize() changing the mapping's
> minimum folio order.
>
> Patch 4 makes the buffered read path honor IOCB_NOWAIT instead of
> blocking on i_rwsem.
>
> Patch 5 makes IOCB_ATOMIC writes fail instead of tearing, and patch 6
> stops the buffered fallback from retrying an atomic write. Block
> devices can reject both paths into the fallback before submitting any
> I/O, so we fail rather than issue a WARN() like ext4 does. Patch 7
> makes iomap_file_buffered_write() reject IOCB_ATOMIC, so no other
> buffered fallback can complete an atomic write either.
>
> Patch 8 fixes leaked page pins in bio_iov_iter_align_down(), and patch
> 9 removes dead metadata handling in the async direct I/O path.
>
> These issues are currently unlikely to be hit in practice due to the
> specific configurations required to trigger them.
>
> The reproducer for patch 1 is in blktests as block/048, and tests for
> patches 2, 3 and 8 are posted at [2].
This is based against the 7.3 series for some reason, can you please
resend against the 7.4 based branch, for-7.4/block.
--
Jens Axboe
prev parent reply other threads:[~2026-10-07 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 23:56 Tal Zussman
2026-09-23 23:56 ` [PATCH v5 1/9] block: use iomap_dirty_folio for block devices Tal Zussman
2026-09-23 23:56 ` [PATCH v5 2/9] block: take i_rwsem for the direct I/O write fallback Tal Zussman
2026-09-23 23:56 ` [PATCH v5 3/9] block: take i_rwsem for the splice read path Tal Zussman
2026-09-23 23:56 ` [PATCH v5 4/9] block: honor IOCB_NOWAIT in the block device buffered " Tal Zussman
2026-09-23 23:56 ` [PATCH v5 5/9] block: fail a short atomic pin in bio_iov_iter_get_pages() Tal Zussman
2026-09-25 5:14 ` Hannes Reinecke
2026-09-25 13:37 ` John Garry
2026-09-29 8:47 ` Tal Zussman
2026-09-23 23:56 ` [PATCH v5 6/9] block: don't fall back to buffered I/O for atomic writes Tal Zussman
2026-09-23 23:56 ` [PATCH v5 7/9] iomap: reject atomic writes in iomap_file_buffered_write() Tal Zussman
2026-09-24 7:25 ` John Garry
2026-09-25 5:14 ` Hannes Reinecke
2026-09-23 23:56 ` [PATCH v5 8/9] block: unpin all pages of a bvec in bio_iov_iter_align_down() Tal Zussman
2026-09-23 23:56 ` [PATCH v5 9/9] block: remove dead metadata handling from the async direct I/O path Tal Zussman
2026-10-07 14:05 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=960b1305-c5a6-4554-8bab-1cf4244fa11b@kernel.dk \
--to=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=john.garry@linux.dev \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mkp@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=tz2294@columbia.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®