mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chi Zhiling <chizhiling@163.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: exfat@lists.linux.dev, linux-kernel@vger.kernel.org,
	Sungjong Seo <sj1557.seo@samsung.com>,
	Yuezhang Mo <yuezhang.mo@sony.com>,
	Chi Zhiling <chizhiling@kylinos.cn>
Subject: Re: [RFC PATCH v1 3/6] exfat: use atomic bit ops for volume dirty flag
Date: Thu, 27 Aug 2026 10:08:13 +0800	[thread overview]
Message-ID: <9614e8fd-c12c-4a0c-bba4-d2469d7b19aa@163.com> (raw)
In-Reply-To: <CAKYAXd_gZFJ8P-pk1RijAVtB9A4PdHG8fcwHRAUsS+Kum_3ALg@mail.gmail.com>

Hi, Namjae

You are right. This should not be removed. I will restore it in the
next version.


Thanks,

On 8/27/26 9:03 AM, Namjae Jeon wrote:
>> -static int exfat_set_vol_flags(struct super_block *sb, unsigned short new_flags)
>> +static int exfat_sync_vol_flags(struct super_block *sb)
>>   {
>>          struct exfat_sb_info *sbi = EXFAT_SB(sb);
>>          struct boot_sector *p_boot = (struct boot_sector *)sbi->boot_bh->b_data;
>>
>> -       /* retain persistent-flags */
>> -       new_flags |= sbi->vol_flags_persistent;
> Please don't remove ->vol_flags_persistent. It prevents pre-existing
> volume dirty flags from being lost, but removing it clears a dirty
> flag set before mount during normal unmount.


  reply	other threads:[~2026-08-27  2:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 10:05 [RFC PATCH 0/6] exfat: take s_lock in read mode for iomap mapping paths Chi Zhiling
2026-08-21 10:05 ` [RFC PATCH v1 1/6] exfat: remove dead hint_bmap updates in I/O and truncate paths Chi Zhiling
2026-08-21 10:05 ` [RFC PATCH v1 2/6] exfat: take bitmap_lock at the start of exfat_alloc_cluster() Chi Zhiling
2026-08-21 10:05 ` [RFC PATCH v1 3/6] exfat: use atomic bit ops for volume dirty flag Chi Zhiling
2026-08-27  1:03   ` Namjae Jeon
2026-08-27  2:08     ` Chi Zhiling [this message]
2026-08-21 10:05 ` [RFC PATCH v1 4/6] exfat: lock FAT2 buffer while copying mirrored FAT entries Chi Zhiling
2026-08-21 10:05 ` [RFC PATCH v1 5/6] exfat: convert s_lock mutex to rw_semaphore using write lock Chi Zhiling
2026-08-21 10:05 ` [RFC PATCH v1 6/6] exfat: take s_lock in read mode for iomap mapping paths Chi Zhiling
2026-08-27  1:08   ` Namjae Jeon
2026-08-27  2:21     ` Chi Zhiling
2026-08-27  6:54       ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9614e8fd-c12c-4a0c-bba4-d2469d7b19aa@163.com \
    --to=chizhiling@163.com \
    --cc=chizhiling@kylinos.cn \
    --cc=exfat@lists.linux.dev \
    --cc=linkinjeon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sj1557.seo@samsung.com \
    --cc=yuezhang.mo@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®