From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966145AbXDIQZM (ORCPT ); Mon, 9 Apr 2007 12:25:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S966148AbXDIQZM (ORCPT ); Mon, 9 Apr 2007 12:25:12 -0400 Received: from py-out-1112.google.com ([64.233.166.183]:21882 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966147AbXDIQZK (ORCPT ); Mon, 9 Apr 2007 12:25:10 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=KMBjcj/CvL7KBHMNFarbYv9HSjZVbndFuhob5+mxdw7i4DbR6vkl4OJwFkIWEZrtS6htGF2CksEE6ZfIlE5+qkzWoJ8c99cMgtInQCk18H5+o1hZOcf13gzEriPuQA7OUovK7WM2daPqBWvvn9etVil6hhsZO0jt3yJ7S5lb1lY= Message-ID: <961aa3350704090925q6e8659c9od3803d6cac35b455@mail.gmail.com> Date: Tue, 10 Apr 2007 01:25:09 +0900 From: "Akinobu Mita" To: "Matt Mackall" Subject: Re: [PATCH] slob: handle SLAB_PANIC flag Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org In-Reply-To: <20070409145758.GO4892@waste.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070409130847.GA5048@APFDCB5C> <20070409145758.GO4892@waste.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org 2007/4/9, Matt Mackall : > > Index: 2.6-mm/mm/slob.c > > =================================================================== > > --- 2.6-mm.orig/mm/slob.c > > +++ 2.6-mm/mm/slob.c > > @@ -298,6 +298,9 @@ struct kmem_cache *kmem_cache_create(con > > c->align = (flags & SLAB_MUST_HWCACHE_ALIGN) ? SLOB_ALIGN : 0; > > if (c->align < align) > > c->align = align; > > + } else { > > + if (flags & SLAB_PANIC) > > + panic("Cannot create slab cache %s\n", name); > > } > > I think this would be more canonical: > > } else if (..) > panic(); Thanks, the patch updated. From: Akinobu Mita Subject: [PATCH] slob: handle SLAB_PANIC flag kmem_cache_create() for slob doesn't handle SLAB_PANIC. Signed-off-by: Matt Mackall Signed-off-by: Akinobu Mita --- mm/slob.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: 2.6-mm/mm/slob.c =================================================================== --- 2.6-mm.orig/mm/slob.c +++ 2.6-mm/mm/slob.c @@ -298,7 +298,8 @@ struct kmem_cache *kmem_cache_create(con c->align = (flags & SLAB_MUST_HWCACHE_ALIGN) ? SLOB_ALIGN : 0; if (c->align < align) c->align = align; - } + } else if (flags & SLAB_PANIC) + panic("Cannot create slab cache %s\n", name); return c; }