From: "Akinobu Mita" <akinobu.mita@gmail.com>
To: "Grant Likely" <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org,
"Eberhard Moenkeberg" <emoenke@gwdg.de>,
"Joe Thornber" <dm-devel@redhat.com>
Subject: Re: [PATCH 2/4] void unregister_blkdev - delete redundant messages
Date: Sat, 30 Jun 2007 23:08:06 +0900 [thread overview]
Message-ID: <961aa3350706300708l3bd4ab31ob9646847ea4f4537@mail.gmail.com> (raw)
In-Reply-To: <fa686aa40706292314g3323c98dxdecd8b5a289f1c64@mail.gmail.com>
2007/6/30, Grant Likely <grant.likely@secretlab.ca>:
> On 6/29/07, Akinobu Mita <akinobu.mita@gmail.com> wrote:
> > No need to warn unregister_blkdev() failure by the callers.
> > (The previous patch makes unregister_blkdev() print error message in
> > error case)
>
> Seeing as none of the callers check the error code; why does the
> function return anything at all?
Right. This series of patches is trying to make it return void.
http://lkml.org/lkml/2007/6/29/320
next prev parent reply other threads:[~2007-06-30 14:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-30 3:10 [PATCH 1/4] void unregister_blkdev - do WARN_ON failure Akinobu Mita
2007-06-30 3:12 ` [PATCH 2/4] void unregister_blkdev - delete redundant messages Akinobu Mita
2007-06-30 3:13 ` [PATCH 2/4 -mm] void unregister_blkdev - delete redundant message Akinobu Mita
2007-06-30 6:15 ` Grant Likely
2007-06-30 6:14 ` [PATCH 2/4] void unregister_blkdev - delete redundant messages Grant Likely
2007-06-30 14:08 ` Akinobu Mita [this message]
2007-06-30 14:12 ` Grant Likely
2007-06-30 3:15 ` [PATCH 3/4] void unregister_blkdev - ignore the return value Akinobu Mita
2007-06-30 3:17 ` [PATCH 4/4] void unregister_blkdev - make void Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=961aa3350706300708l3bd4ab31ob9646847ea4f4537@mail.gmail.com \
--to=akinobu.mita@gmail.com \
--cc=dm-devel@redhat.com \
--cc=emoenke@gwdg.de \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®