From: "Akinobu Mita" <akinobu.mita@gmail.com>
To: "Harvey Harrison" <harvey.harrison@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"Marcel Holtmann" <marcel@holtmann.org>
Subject: Re: [PATCH 1/2] lib: export bitrev16
Date: Thu, 5 Jun 2008 00:04:32 +0900 [thread overview]
Message-ID: <961aa3350806040804g72c85ca3ide63ab2b0074ccf2@mail.gmail.com> (raw)
In-Reply-To: <1212517160.11008.59.camel@brick>
> --- a/lib/bitrev.c
> +++ b/lib/bitrev.c
> @@ -42,10 +42,11 @@ const u8 byte_rev_table[256] = {
> };
> EXPORT_SYMBOL_GPL(byte_rev_table);
>
> -static __always_inline u16 bitrev16(u16 x)
> +u16 bitrev16(u16 x)
> {
> return (bitrev8(x & 0xff) << 8) | bitrev8(x >> 8);
> }
> +EXPORT_SYMBOL(bitrev16);
How about just moving bitrev16() from lib/bitrev.c to include/linux/bitrev.h
with s/__always_inline/inline/ rather than making it export symbol?
prev parent reply other threads:[~2008-06-04 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 18:19 Harvey Harrison
2008-06-04 6:46 ` Marcel Holtmann
2008-06-04 15:04 ` Akinobu Mita [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=961aa3350806040804g72c85ca3ide63ab2b0074ccf2@mail.gmail.com \
--to=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®