From: "Akinobu Mita" <akinobu.mita@gmail.com>
To: "James Bottomley" <James.Bottomley@hansenpartnership.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
"Brian King" <brking@us.ibm.com>
Subject: Re: [PATCH -mm] fix ipr-use-memory_read_from_buffer.patch
Date: Sat, 5 Jul 2008 02:18:49 +0900 [thread overview]
Message-ID: <961aa3350807041018p437a2d60ka5936758bf7573d5@mail.gmail.com> (raw)
In-Reply-To: <1215191136.5413.13.camel@localhost.localdomain>
>> --- 2.6-mm.orig/drivers/scsi/ipr.c
>> +++ 2.6-mm/drivers/scsi/ipr.c
>> @@ -71,6 +71,7 @@
>> #include <linux/module.h>
>> #include <linux/moduleparam.h>
>> #include <linux/libata.h>
>> +#include <linux/string.h>
>> #include <asm/io.h>
>> #include <asm/irq.h>
>> #include <asm/processor.h>
>
> This isn't really necessary, is it? As you can see from the file being
> stuffed full of memcpy directives, it's already getting an implicit
> include of string.h from somewhere (like the rest of the SCSI drivers).
Indeed. This is not necessary.
next prev parent reply other threads:[~2008-07-04 17:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200807040647.m646lXpN017508@imap1.linux-foundation.org>
[not found] ` <1215182555.5413.8.camel@localhost.localdomain>
2008-07-04 16:39 ` [PATCH] move memory_read_from_buffer() from fs.h to string.h Akinobu Mita
2008-07-04 16:48 ` [PATCH -mm] fix s390-use-memory_read_from_buffer.patch Akinobu Mita
2008-07-04 16:51 ` [PATCH -mm] fix s390-cio-use-memory_read_from_buffer.patch Akinobu Mita
2008-07-04 16:53 ` [PATCH -mm] fix qla2xxx-use-memory_read_from_buffer.patch Akinobu Mita
2008-07-04 16:54 ` [PATCH -mm] fix ipr-use-memory_read_from_buffer.patch Akinobu Mita
2008-07-04 17:05 ` James Bottomley
2008-07-04 17:18 ` Akinobu Mita [this message]
2008-07-04 16:55 ` [PATCH -mm] fix dcdbas-use-memory_read_from_buffer.patch Akinobu Mita
2008-07-04 16:57 ` [PATCH -mm] fix aty-use-memory_read_from_buffer.patch Akinobu Mita
2008-07-04 16:58 ` [PATCH -mm] fix firmware-use-memory_read_from_buffer.patch Akinobu Mita
2008-07-04 17:00 ` [PATCH -mm] fix dell_rbu-use-memory_read_from_buffer.patch Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=961aa3350807041018p437a2d60ka5936758bf7573d5@mail.gmail.com \
--to=akinobu.mita@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=brking@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®