From: Akinobu Mita <akinobu.mita@gmail.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] failslab: add abitily to filter slab caches
Date: Tue, 23 Feb 2010 23:08:07 +0900 [thread overview]
Message-ID: <961aa3351002230608l5d5cbf88v41b3d645cfafccd5@mail.gmail.com> (raw)
In-Reply-To: <87mxz0vymx.fsf@openvz.org>
2010/2/23 Dmitry Monakhov <dmonakhov@openvz.org>:
> Akinobu Mita <akinobu.mita@gmail.com> writes:
>
>> 2010/2/23 Dmitry Monakhov <dmonakhov@openvz.org>:
>>> Example:
>>> echo 1 > /sys/kernel/slab/skbuff_head_cache/failslab
>>> echo 1 > /sys/kernel/debug/failslab/cache-filter
>>
>> Looks good.
>>
>> .Should we also support clearing the flag by
>> "echo 0 > /sys/kernel/slab/skbuff_head_cache/failslab" ?
> But it already does this, any output except "1" treated as '0'
> I've snipped this from trace option.
Oops, you are right.
>>
>>> +static ssize_t failslab_store(struct kmem_cache *s, const char *buf,
>>> + size_t length)
>>> +{
>>> + s->flags &= ~SLAB_FAILSLAB;
>>> + if (buf[0] == '1')
>>> + s->flags |= SLAB_FAILSLAB;
>>> + return length;
>>> +}
>>> +SLAB_ATTR(failslab);
>
next prev parent reply other threads:[~2010-02-23 14:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 13:32 Dmitry Monakhov
2010-02-23 13:58 ` Akinobu Mita
2010-02-23 14:02 ` Dmitry Monakhov
2010-02-23 14:08 ` Akinobu Mita [this message]
2010-02-23 22:36 ` David Rientjes
2010-02-24 18:38 ` [PATCH] failslab: add ability " Dmitry Monakhov
2010-02-24 21:21 ` David Rientjes
2010-02-25 5:50 ` Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=961aa3351002230608l5d5cbf88v41b3d645cfafccd5@mail.gmail.com \
--to=akinobu.mita@gmail.com \
--cc=dmonakhov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®