From: Rohit Kumar <rohitkr@codeaurora.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>
Cc: Ajit Pandey <ajitp@codeaurora.org>,
rohkumar@qti.qualcomm.com, alsa-devel@alsa-project.org,
bgoswami@codeaurora.org, vinod.koul@linaro.org,
linux-kernel@vger.kernel.org, plai@codeaurora.org,
tiwai@suse.com, lgirdwood@gmail.com, asishb@codeaurora.org,
srinivas.kandagatla@linaro.org
Subject: Re: [alsa-devel] Applied "ASoC: soc-core: defer card probe until all component is added to list" to the asoc tree
Date: Thu, 10 Jan 2019 12:39:13 +0530 [thread overview]
Message-ID: <961ef85b-86a5-1db8-260b-6c5cb27399fe@codeaurora.org> (raw)
In-Reply-To: <874lahb6bi.wl-kuninori.morimoto.gx@renesas.com>
Thanks Kuninori for reporting the issue.
On 1/10/2019 8:02 AM, Kuninori Morimoto wrote:
> Hi Mark, Ajit
>
>> From: Ajit Pandey <ajitp@codeaurora.org>
>> Date: Wed, 9 Jan 2019 14:17:07 +0530
>> Subject: [PATCH] ASoC: soc-core: defer card probe until all component is added
>> to list
>>
>> DAI component probe is not called if it is not present
>> in component list during sound card registration.
>> Check if component is available in component list for
>> platform and cpu dai before soundcard registration.
>>
>> Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
>> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
>> Signed-off-by: Mark Brown <broonie@kernel.org>
>> ---
> I got below WARNING by this patch.
> I guess we need mutex_lock() on snd_soc_register_card() ?
Right, we should have client_mutex lock before calling
soc_find_component().
We will post fix.
>
> ...
> [drm] Device feb00000.display probed
> [drm] Cannot find any crtc or sizes
> [drm] Cannot find any crtc or sizes
> WARNING: CPU: 0 PID: 76 at sound/soc/soc-core.c:739 soc_find_component+0xb8/0xc0
> CPU: 0 PID: 76 Comm: kworker/0:1 Not tainted 5.0.0-rc1+ #1360
> Hardware name: Renesas H3ULCB Kingfisher board based on r8a7795 ES2.0+ (DT)
> Workqueue: events deferred_probe_work_func
> pstate: 60000005 (nZCv daif -PAN -UAO)
> pc : soc_find_component+0xb8/0xc0
> lr : soc_find_component+0xb4/0xc0
> sp : ffff00001217ba10
> x29: ffff00001217ba10 x28: 0000000000000000
> x27: ffff000010a82920 x26: 0000000000000000
> x25: ffff8006f9c59900 x24: ffff0000105f33a0
> x23: ffff000010948d70 x22: 0000000000000000
> x21: ffff000010af1720 x20: ffff8006ff80b6d8
> x19: ffff8006f8523080 x18: 0000000000000010
> x17: 0000000000000000 x16: 0000000000000000
> x15: ffffffffffffffff x14: 0720072007200720
> x13: 0720072007200720 x12: 0720072007200720
> x11: 0720072007200720 x10: 0720072007200720
> x9 : 0000000000000000 x8 : ffff000010a85000
> x7 : ffff000010114bd4 x6 : 0000000000000001
> x5 : 0000000000000018 x4 : 0000000000000001
> x3 : 0000000000000000 x2 : 0000000000000003
> x1 : ffff000010af17b0 x0 : 0000000000000000
> Call trace:
> soc_find_component+0xb8/0xc0
> soc_init_dai_link+0x18c/0x210
> snd_soc_register_card.part.16+0x138/0x198
> snd_soc_register_card+0x30/0x48
> devm_snd_soc_register_card+0x4c/0xa0
> graph_probe+0x2d8/0x388
> platform_drv_probe+0x58/0xa8
> really_probe+0x1c0/0x2a0
> driver_probe_device+0x5c/0xf0
> __device_attach_driver+0x9c/0xe0
> ...
Regards,
Rohit
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.
next prev parent reply other threads:[~2019-01-10 7:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 8:47 [PATCH v2] ASoC: soc-core: defer card probe until all component is added to list Rohit kumar
2019-01-09 12:49 ` Applied "ASoC: soc-core: defer card probe until all component is added to list" to the asoc tree Mark Brown
2019-01-10 2:32 ` [alsa-devel] " Kuninori Morimoto
2019-01-10 7:09 ` Rohit Kumar [this message]
2019-01-10 7:29 ` Kuninori Morimoto
2019-01-11 5:07 ` [alsa-devel] [PATCH v2] ASoC: soc-core: defer card probe until all component is added to list Pierre-Louis Bossart
2019-01-11 8:11 ` Rohit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=961ef85b-86a5-1db8-260b-6c5cb27399fe@codeaurora.org \
--to=rohitkr@codeaurora.org \
--cc=ajitp@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=asishb@codeaurora.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=rohkumar@qti.qualcomm.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome