From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B8A1274FE3 for ; Fri, 31 Jul 2026 11:02:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785495775; cv=none; b=IBgzzRuFRgBBVnHR5SfGd/kPYIY/BKlNM/TTWZk9qvMCj1+KTVPFTErCE5CKppXzjSO0wKFz4eLDElys037pufyrdjr4KCZO1HeG34a8AOEBXuXWMexm9fiUO5CiFe1887eQ+qA/siQIM6XZGmJNU3iAlTnpSr2LfvUvJ/B6Hss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785495775; c=relaxed/simple; bh=kOOmbLFrG8QsZwkEOkrXY4yYRRBcRDCtei1KlyOaFog=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hSqKTMge+V81K4oxLCGaPXmjQZSE9kJYhhza9N0amr5Du6MAaQI2dI4P9+cgcx7wusb5DbtMC9CV1sbi/f/co9oqujZaD3CUP/cqAhHZnfHJs+IoMCPL9JCm2DYvYB3GjXpV1Hh6L/KCBfZpj5EdPBqKf3eU450VuhLbK+ynnTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HwiQ9wyI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hHMKfKQv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HwiQ9wyI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hHMKfKQv" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66VB0ae1800797 for ; Fri, 31 Jul 2026 11:02:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GLY9j9Bk41aAiT69kbw7H9yfLznQqyIDZa0bLbpKQhs=; b=HwiQ9wyI4kUtSogO w0Ia0DA0/+zGXersKzKidABSr6xm9ehcho3hsRW6Lr8wSYDmlGsB/C+LYkNE4I90 8Z8TNpGnhtf17noY9yQdM9VIvETkgkZc3g6RInUt/vlMvWbLwtbuJM9lgE45Y9Tl C1jLNB+jdXpyrwxZI7s0EVu5mquTghI9OUUDbxQkYn/V/eQBxkBrWq7FZQ2ieaYJ kClnM1TuBbmDJ5PBI5HcoTEIAxiL4LQTEzg3Ubpu/E60TGM4bEV5vN6wn1i77YhK YzK8caDKz/lVmDGPHbjCQkRKzQK6yNVpzgAsHWxtvYfAK57GaUEjXmTDH0tFjo+7 /B/Otg== Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frtf2r08x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 11:02:50 +0000 (GMT) Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-48ade85cef5so109437b6e.0 for ; Fri, 31 Jul 2026 04:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785495770; x=1786100570; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GLY9j9Bk41aAiT69kbw7H9yfLznQqyIDZa0bLbpKQhs=; b=hHMKfKQvOmfHG+MUIgfDwyadSRt4lBkLkYToViTCcIzuFsVqK1nJUHz3GircyY5tGU 6WkJDB9hMPwWJL1PvH/LMYgiepO0zj9wt65cZxS0jr5iDyO2lgT57cM7AD20pog5Uio0 AZWE8BJRR9W/7cVEY49iQhZaj5Ti7IzfWhdsp8a6UZwj9EVgUY+D8TznaPNKrW1NUjTE sZqJZsYtEto3IEM/UOINd1Wjb8TkVblCq61q54XLb7b2dpTGFeXOUrbo/HSH91oNyHtG tXbhLHwx3f+koAgnaayB/dn6gv9iZ01bZstzu+r3nxX1x2Uq3sGU5gg813mLFNd2pP4Q hahw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785495770; x=1786100570; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GLY9j9Bk41aAiT69kbw7H9yfLznQqyIDZa0bLbpKQhs=; b=JUd9Kw7AVP4vVTz3NqxlqcwqiZVD0JiI5KhwxPSR6ABefI0Z2moHGusfI3jQS/p1BI /6XtZNXR2/Xw8i/8dC7Tba/8x+/2UF/sYZrXviIfr5Ei2pBzaeJ0/qRpg8IhYDlAsuES gs4n35dUsKrx1oJY6fqOuMMj6TieLHfRMhuxDKQQ8RzL38JmBWGnUrbguALH/nLsRCmY /xL40IMLzk5QLaEJ2tnJqnksVN5ExEcbrIT2AgbLnILaoA/o456Hlsg3wCtdHMuyxDB5 mJWnND7VXwlxM7vCcMuP2KgvjrzYONDJJJWSVdxgs/AhNyBklp4SxWSk24RToXIg36Fs 39Hg== X-Forwarded-Encrypted: i=1; AHgh+Rp2Dp1DqPbJQmqT2b5zHcJR4OsIQt1i3BJIRcSc3TkwNunYuuuDiqrnz2tSx0BEgG8dk5dTis8IXPZvBGw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0mRj6yQKW1pQsK3HpliqzaqeudsDHflX3cqPHdamMF9SNnPjL VkxCNNFW31bvxRhrPY2Icb4XDFslipH3UhCyXP0D945R+r62DNV40r5PsGz6MVmn5VHPO3e0dmR HkpMBWrWSVvCnwcEuHc1fr7KIweMQg69/je2am93JcSdnNI1cbDDucBTPaaaQQo3XW4U= X-Gm-Gg: AR+sD11agHebA4Q+E8q/4nl1IdInajEmmwGicoDYBRi4GZ2nUAQ+7rWYIY5ksbs0VgW m98j4vKctKA2LQOf53JFjG+JV3FYd+8lcPQEJh9LypgzKiW5p/XwDpTxv/WaHushKEa5DPx1XD9 cUJ9J3X+icGIhAC2Z9y3CQeN9Oo13lbrQQjBI5mW8JmZeCf7H0dmJOpCy7SBWC15XilqVRP30vD KbUM8v20mk7xiECP3G/gKXy36mT+BidjeGHsoMB514UUrbbXfp8mbff4kThvj4Qm1d/+gwL4O+/ FDw4UvvKaprw4GCbQvZipf60zwfY/mqehRrK6/wam8Ugx2zzWPd1Ys3TJ1DvqOXsoEHD8klto7H jtheS97tjlTAweXG315/jnH8e X-Received: by 2002:a05:6808:15a3:b0:496:d5:7b22 with SMTP id 5614622812f47-4ae4c44f120mr1014188b6e.1.1785495770102; Fri, 31 Jul 2026 04:02:50 -0700 (PDT) X-Received: by 2002:a05:6808:15a3:b0:496:d5:7b22 with SMTP id 5614622812f47-4ae4c44f120mr1014178b6e.1.1785495769744; Fri, 31 Jul 2026 04:02:49 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd3c5b0fasm113417766b.5.2026.07.31.04.02.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 04:02:48 -0700 (PDT) Message-ID: <96246a96-31ad-48d8-b32e-2c4df5830d96@oss.qualcomm.com> Date: Fri, 31 Jul 2026 13:02:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] power: supply: qcom_battmgr: fix use-after-free of battmgr on remove To: Fan Wu , linux-pm@vger.kernel.org Cc: sre@kernel.org, andersson@kernel.org, neil.armstrong@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260731022006.317192-1-fanwu01@zju.edu.cn> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260731022006.317192-1-fanwu01@zju.edu.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: p6l3P6gvGS2A_g883tWFX74DWXZ44qmC X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDA4MiBTYWx0ZWRfX99sfe2W3cah9 qWjdYr0LavMubqR1F/6tI0l6XezxusDSNYOTHPK2oZ1xnmzsYoYl16+dCFjN6sVb8liLA7q+uLh fUeJrK4TOGVgxaA/YCycqvu46sIl+sA= X-Proofpoint-GUID: p6l3P6gvGS2A_g883tWFX74DWXZ44qmC X-Authority-Analysis: v=2.4 cv=ddKwG3Xe c=1 sm=1 tr=0 ts=6a6c80da cx=c_pps a=4ztaESFFfuz8Af0l9swBwA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=aDI3_xmd8nExmCF51jIA:9 a=QEXdDO2ut3YA:10 a=TPnrazJqx2CeVZ-ItzZ-:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDA4MiBTYWx0ZWRfX4z2CMvdu6YDI WA+ZACKF3T3+8cwl6ROXdg81RUMVR1uziIUWwdQIq6Q6w4VMIMWLD4hYkNPcIXMDg7HiqgClGLb JdU1HK0/d/jejjubIx1ymzI2ixdU/sw1utq4HhjJaSEI1/hvc+PTqvilTNWUMsVN3y91xbgqaF6 26tEdCCt0QRWTmYA78oenUeynMNo3+M2Fx4lXhIi4Vt8Vn7g/OkMcv3BOMyYAbJWg1AV8CSpYAX o7DKwpMw+LD73GuAvxgsWbwK0/e12+EtQll2y0aVPFeEJP9X2DB+vUGxt1JI21yyoC2ma76zUrh qIrblOIpviSXbIqYTRrlVA+7AV5TAM+/QTPw6UiZr8pkgr/LgyBl0vv4SIcwqFbnB1UkMfIxK0V 6eh6icCsK9VKIWO8vrnXTtkgdXy/jHKSgT8p+6NQTU7FblGsffc/0mQesL3WmLPmyFOUj/Q3JKp b8OD6QWLntiM0vpmyMw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_03,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310082 On 7/31/26 4:20 AM, Fan Wu wrote: > qcom_battmgr_pdr_notify() queues enable_work when the PMIC GLINK service > comes up. The worker recovers battmgr through container_of() and issues a > firmware request. > > The driver has no remove callback, so a pending or running enable_work can > access battmgr after devres frees it. The PMIC GLINK client stays on the > client list until its devres release action, so a PDR notification can > also queue the work while remove is running. > > Add a remove callback that disables and drains enable_work before devres > release. Unlike cancel_work_sync(), disable_work_sync() also blocks a later > PDR notification from queueing the work. Store battmgr with > auxiliary_set_drvdata() in probe so remove can retrieve it. > > This issue was found by an in-house static analysis tool. > > Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply") > Cc: stable@vger.kernel.org # v6.10+ > Assisted-by: Codex:gpt-5.6 > Signed-off-by: Fan Wu > --- Reviewed-by: Konrad Dybcio Konrad