From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06637340282 for ; Wed, 6 May 2026 22:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778106109; cv=none; b=UshS5HTUvJMjnv0Vc1JuyOdfWjsQ5rz68mt0tI/UYSBmar8PNYQAk8Q+Fg2xuoSUcHAw1h2+we8jA7L/OrDZP4iv6aRpbVa69GN2lBBY4yFyMHNdItati9aivmdq34OHP+TCjS5Xexr12lOEWwBNbklUNsqhEMCS1wpTcGDTyYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778106109; c=relaxed/simple; bh=2juvgxjW5b9ZVDatfg1vz08IAt5uhUG2nGLLSx9mCL0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=diIm0OUmhy2vkOD27VlekQxypBoCgLaOqTWaJllTYcfE9a5wrXdcBbex/hQTF3OisNFQZ1XBlgyXVqANriiMrg/bDgUnf/1NSHcy6K15HHs8KEXjrLIS5umLK4V1valscnHrcMgcWwF6Y398HQEdS3f3iizmdldotWE2jKXf+dA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=esnaY6OC; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IGMgD6Ux; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="esnaY6OC"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IGMgD6Ux" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778106107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2juvgxjW5b9ZVDatfg1vz08IAt5uhUG2nGLLSx9mCL0=; b=esnaY6OCxUHTkrtY0C7kb2Mtgdo/oYY0JRuNG+dbBwlVAYTsEiLGxy2EcYkMvY18lma5fA h3tZS4byBRaR4siBJH+DM4eqf7h99CH2YVelm9QqwHHeej6mbSL7OTZfOFVYfIL8O18QPS QQ8DJ/pgRkYh/pZ5fzJHPGF2EIM1a7g= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-1SbJwVuLOhqmrPA_v04IBg-1; Wed, 06 May 2026 18:21:45 -0400 X-MC-Unique: 1SbJwVuLOhqmrPA_v04IBg-1 X-Mimecast-MFC-AGG-ID: 1SbJwVuLOhqmrPA_v04IBg_1778106105 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50da529ff48so2232541cf.3 for ; Wed, 06 May 2026 15:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778106105; x=1778710905; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=2juvgxjW5b9ZVDatfg1vz08IAt5uhUG2nGLLSx9mCL0=; b=IGMgD6Uxe+eFouI6+MWdadMYSQfyADEPPLIYufIEYcmvZftLyrl0L05/qkhNdpGOyI jKIJcqWKOfb+eEE+lBrb3ILzsoroARwt4lAMoBHMLJ7uzBY5VgvjBGxE5K6YSsVsMwGG 7JHWEvu/RUgB8Lm0BRyzkR0hy5+4HtUNOAGz9pJOsMgQndMzl1SSRYI9nmKoIs53tepq m4kzzk2lTQE+YnTfZEwIAlKDIztshc0YzzfCRp4rE4fBI/GvGY3yYtIhv4IMGhhjMONs pwGer4D69LVWCEXtv67pFbEuU1ZqX0aGKqU9W+XEu00FVMrXmdwBmcVdhkEDFFMYlXy9 XjCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778106105; x=1778710905; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2juvgxjW5b9ZVDatfg1vz08IAt5uhUG2nGLLSx9mCL0=; b=bWua0086jIqJUkrbDOb+YOxhmWNSX2Z3Bc9IiumqPVKA5JxOfcnZAc2FVdDLBeX3Lw TGRf6p8bYC8OWgrZKzI3F1j+3vTJMf8dYNmMpraFANmTIIzmk+29mXwZMbjecJwUPyb6 M0XCpjdEnuE/bznlkwTQK1xr9/c7mEIriEs8EIF498J3lVzoYNiMJBbK3+dfJxGk3Dfx VPOUIcDSW881RVQo3Y1W7gg3RGPXXqGU7VKtXh6xWkSgER/yS8SpiA1qplpdkE2VMU4t 9ARZ7JrVZ9KlKEes6ltzb0/x/QG0T5HPS54mxzcIejum9y7VpTTU2FIys1H6Klx88G6R zS3Q== X-Forwarded-Encrypted: i=1; AFNElJ/GEc21VNJ3vLZgLi0cqq4p0xJVYq/JbW3saulSZ8kxTFA385n2D4mW0/x3UJgjtLx/aBQDwAMyt4Z/zEA=@vger.kernel.org X-Gm-Message-State: AOJu0YxA8sKjiyVnZZW6E5LDkLiuRsvsjNp0d6XQ4QMnpy9Pu/eBk8qR r0dFHx3KP82+IbBcIY9EN/9gm3Odaxt7497bMEoaDXbx5cnUMSQ3XFX9P0+gTkZPa9Lij3ye7IS XxJUr9LcUBTE+VjyFPdVUR7g/DvmLvQK9KxNxXHS9OsfDfc4NRRRm4Q3APoiNUybTzg== X-Gm-Gg: AeBDies/nvSx8kC5iLXcMI8xME0PiNYOTCI3j/3nUGCgzbWVXPvih1obgEafd81rd0J knlwk+HZ5enouojyjk42vrQfd6F6eBMrGXrzg/8CaZT5IANnAOmmbOldEul+YrMBSooGaE1VhoY 17ryFghHsquqHm2851sD3Nto5eTrw7xCchx+gpZvOESs7crXA3n7wUmJ+iP+zEV6rQ66awqfpSX Ljpe9IXtLJV+BvEbTiQewaVI/AO4PVwB2xD0n30oLm+VU6MXOyVzlZG7IvflKJiaEYUHRXQo8It HxtDs8+YnmVR5+56G6r4n6Qa96tWxFpm2gmmGG9mhwlhNIL62gVu+ACsLUXUJpNWkbbnXwUOwE4 6QDIlYu9oYLLG1SU3KENGrqvqtMcOcKtrMJVZ7WW1k3DFHEUPl/8DwAJyvEIr9exqpd9p X-Received: by 2002:a05:622a:8ce:b0:50f:783f:31a6 with SMTP id d75a77b69052e-51461f7e899mr77483441cf.38.1778106105156; Wed, 06 May 2026 15:21:45 -0700 (PDT) X-Received: by 2002:a05:622a:8ce:b0:50f:783f:31a6 with SMTP id d75a77b69052e-51461f7e899mr77483081cf.38.1778106104727; Wed, 06 May 2026 15:21:44 -0700 (PDT) Received: from loberman-thinkpadp16gen3.rmtusma.csb ([2600:6c65:2440:d8c:aa2b:ddff:fe88:da74]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5104090bb03sm160576221cf.10.2026.05.06.15.21.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 15:21:43 -0700 (PDT) Message-ID: <9624a8d152197522d353ef7bb2b4928d1c6238ae.camel@redhat.com> Subject: Re: [PATCH 0/2] scsi: smartpqi: fix PCIe hot reset recovery From: Laurence Oberman To: Mateusz Nowicki , don.brace@microchip.com Cc: martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com, storagedev@microchip.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 06 May 2026 18:21:41 -0400 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-05-06 at 14:01 +0000, Mateusz Nowicki wrote: > A PCIe bus reset (e.g. "echo 1 > /sys/bus/pci/devices//reset") > on a > controller without FLR support leaves the HPE SR932i-p Gen10+ > unusable > until reboot: smartpqi registers no pci_error_handlers, so the driver > is not notified, firmware reverts to SIS mode, and all queue mappings > are dropped while the driver still drives PQI. >=20 > Patch 1 adds .reset_prepare / .reset_done reusing > pqi_ofa_ctrl_quiesce() / _unquiesce() / pqi_ctrl_init_resume(). >=20 > Patch 2 raises SIS_CTRL_READY_RESUME_TIMEOUT_SECS from 90s to 180s, > matching the cold-boot path; without this patch 1 fails at the SIS > ready check because firmware boot after reset takes ~125s on the > SR932i-p Gen10+. >=20 > Tested on HPE SR932i-p Gen10+ against Linus' master at 74fe02ce122a. >=20 > Note: the From: header is my Posteo address because my employer's > SMTP > is unavailable for external mailing lists.=C2=A0 The Signed-off-by carrie= s > the Microchip attribution. >=20 > Mateusz Nowicki (2): > =C2=A0 scsi: smartpqi: add pci_error_handlers for bus reset recovery > =C2=A0 scsi: smartpqi: increase SIS ctrl ready resume timeout to 180s >=20 > =C2=A0drivers/scsi/smartpqi/smartpqi_init.c | 47 > +++++++++++++++++++++++++++ > =C2=A0drivers/scsi/smartpqi/smartpqi_sis.c=C2=A0 |=C2=A0 2 +- > =C2=A02 files changed, 48 insertions(+), 1 deletion(-) >=20 > -- > 2.43.0 >=20 >=20 >=20 Hello I did reproduce this so I am testing the patches as well. They look correct to me, I will reply again after testing with a review. Thanks Laurence [2513778.140012] smartpqi 0000:64:00.0: no heartbeat detected - last heartbeat count: 4207808511 [2513778.140031] smartpqi 0000:64:00.0: controller offline: reason code 0x4 (no controller heartbeat detected) [2513778.141346] sd 1:0:0:0: [sda] tag#549 FAILED Result: hostbyte=3DDID_NO_CONNECT driverbyte=3DDRIVER_OK cmd_age=3D18s [2513778.141355] sd 1:0:0:0: [sda] tag#550 FAILED Result:=C2=A0 "xfs_buf_ioend_handle_error+0xd5/0x3f0 [xfs]" at daddr 0x9f78 len 8 error 5 [2513778.141526] XFS (dm-0): log I/O error -5