From: David Hildenbrand <david@redhat.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 2/2] mm/highmem: make nr_free_highpages() return "unsigned long"
Date: Mon, 10 Jun 2024 10:23:13 +0200 [thread overview]
Message-ID: <962615d7-d20f-43c2-84a4-a7b99d8dfeca@redhat.com> (raw)
In-Reply-To: <20240608005144.ypbq4442bh46tmqb@master>
On 08.06.24 02:51, Wei Yang wrote:
> On Fri, Jun 07, 2024 at 10:37:11AM +0200, David Hildenbrand wrote:
>> It looks rather weird that totalhigh_pages() returns an
>> "unsigned long" but nr_free_highpages() returns an "unsigned int".
>>
>> Let's return an "unsigned long" from nr_free_highpages() to be
>> consistent.
>>
>> While at it, use a plain "0" instead of a "0UL" in the !CONFIG_HIGHMEM
>> totalhigh_pages() implementation, to make these look alike as well.
>
> I am not sure why not use 0UL for both?
See my reply to Oscar, thanks for the review!
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-06-10 8:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 8:37 [PATCH v1 0/2] mm/highmem: don't track highmem pages manually David Hildenbrand
2024-06-07 8:37 ` [PATCH v1 1/2] mm/highmem: reimplement totalhigh_pages() by walking zones David Hildenbrand
2024-06-07 21:04 ` David Hildenbrand
2024-06-08 0:48 ` Wei Yang
2024-06-10 3:23 ` Oscar Salvador
2024-06-07 8:37 ` [PATCH v1 2/2] mm/highmem: make nr_free_highpages() return "unsigned long" David Hildenbrand
2024-06-08 0:51 ` Wei Yang
2024-06-10 8:23 ` David Hildenbrand [this message]
2024-06-10 3:40 ` Oscar Salvador
2024-06-10 8:22 ` David Hildenbrand
2024-06-11 0:56 ` Wei Yang
2024-06-11 9:20 ` David Hildenbrand
2024-06-12 7:01 ` Wei Yang
2024-06-12 7:22 ` David Hildenbrand
2024-06-12 7:34 ` Wei Yang
2024-06-08 0:45 ` [PATCH v1 0/2] mm/highmem: don't track highmem pages manually Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=962615d7-d20f-43c2-84a4-a7b99d8dfeca@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®