From: "Arnd Bergmann" <arnd@arndb.de>
To: "Thomas Zimmermann" <tzimmermann@suse.de>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Dave Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Jocelyn Falempe" <jfalempe@redhat.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Jani Nikula" <jani.nikula@intel.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Jonathan Cavitt" <jonathan.cavitt@intel.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: rework FB_CORE dependency
Date: Fri, 15 Nov 2024 17:35:46 +0100 [thread overview]
Message-ID: <96269b2e-2a0e-4c7e-9d47-a52e64d1ea0a@app.fastmail.com> (raw)
In-Reply-To: <a600708e-5240-4c31-ad29-4a6e791a65e7@suse.de>
On Fri, Nov 15, 2024, at 16:54, Thomas Zimmermann wrote:
> Am 15.11.24 um 16:27 schrieb Arnd Bergmann:
>>
>> @@ -220,7 +221,6 @@ config DRM_CLIENT_LIB
>> tristate
>> depends on DRM
>> select DRM_KMS_HELPER if DRM_FBDEV_EMULATION
>> - select FB_CORE if DRM_FBDEV_EMULATION
>
> This should remain. More fbdev code will move into drm_fbdev_client.c
> and that will require FB_CORE.
Got it.
>> help
>> This option enables the DRM client library and selects all
>> modules and components according to the enabled clients.
>> @@ -372,6 +372,7 @@ config DRM_GEM_SHMEM_HELPER
>> tristate
>> depends on DRM && MMU
>> select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
>> + select FB_CORE if DRM_FBDEV_EMULATION
>
> This select is also needed by DRM_GEM_DMA_HELPER and DRM_GEM_TTM_HELPER.
>
> Please sort these select statements alphabetically.
Sent a v2 now.
Arnd
next prev parent reply other threads:[~2024-11-15 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 15:27 Arnd Bergmann
2024-11-15 15:54 ` Thomas Zimmermann
2024-11-15 16:35 ` Arnd Bergmann [this message]
2024-11-17 5:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96269b2e-2a0e-4c7e-9d47-a52e64d1ea0a@app.fastmail.com \
--to=arnd@arndb.de \
--cc=airlied@gmail.com \
--cc=arnd@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=harry.wentland@amd.com \
--cc=jani.nikula@intel.com \
--cc=jfalempe@redhat.com \
--cc=jonathan.cavitt@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=masahiroy@kernel.org \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®