From: Krzysztof Kozlowski <krzk@kernel.org>
To: 김은우 <ew.kim@samsung.com>,
s.nawrocki@samsung.com, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.com
Cc: linux-sound@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: samsung: Implement abox generic structure
Date: Thu, 10 Jul 2025 09:17:09 +0200 [thread overview]
Message-ID: <9627b253-5c43-4cfc-83c1-d5b4d36fd967@kernel.org> (raw)
In-Reply-To: <01a401dbf16a$33fbd0d0$9bf37270$@samsung.com>
On 10/07/2025 09:13, 김은우 wrote:
> Thank you for your review.
> We will proceed to remove unnecessary Doxygen comments and logs as suggested.
Only these, but what about all other comments? Please implement all
comments and do a thorough internal review cleaning all the downstream
stuff from here. Your patchset is also not correctly threaded, so please
read submitting patches or just use `b4`.
Please avoid top-posting.
>
> Based on the feedback provided, we will revise the work accordingly and resubmit it for further review.
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-10 7:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250709002150epcas2p467416bdbc16754726599a0cacb1feecc@epcas2p4.samsung.com>
2025-07-09 0:10 ` ew.kim
2025-07-09 8:46 ` Mark Brown
2025-07-10 7:07 ` 김은우
2025-07-09 13:57 ` Krzysztof Kozlowski
2025-07-10 7:13 ` 김은우
2025-07-10 7:17 ` Krzysztof Kozlowski [this message]
2025-07-09 18:10 ` Christophe JAILLET
2025-07-10 7:19 ` 김은우
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9627b253-5c43-4cfc-83c1-d5b4d36fd967@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ew.kim@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®