From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>, Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-msm@vger.kernel.org,
Banajit Goswami <bgoswami@codeaurora.org>
Subject: Re: [PATCH] ASoC: qcom: lpass-cpu: Use optional clk APIs
Date: Fri, 21 May 2021 10:34:52 +0100 [thread overview]
Message-ID: <96301eb2-ef2d-be7f-2a24-8723c1e39905@linaro.org> (raw)
In-Reply-To: <20210520014807.3749797-1-swboyd@chromium.org>
Thanks Stephen for patch.
On 20/05/2021 02:48, Stephen Boyd wrote:
> This driver spits out a warning for me at boot:
>
> sc7180-lpass-cpu 62f00000.lpass: asoc_qcom_lpass_cpu_platform_probe() error getting optional null: -2
>
> but it looks like it is all an optional clk. Use the optional clk APIs
> here so that we don't see this message and everything else is the same.
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Banajit Goswami <bgoswami@codeaurora.org>
> Fixes: 3e53ac8230c1 ("ASoC: qcom: make osr clock optional")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Lgtm,
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
--srini
> ---
> sound/soc/qcom/lpass-cpu.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c
> index c62d2612e8f5..28c7497344e3 100644
> --- a/sound/soc/qcom/lpass-cpu.c
> +++ b/sound/soc/qcom/lpass-cpu.c
> @@ -835,18 +835,8 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev)
> if (dai_id == LPASS_DP_RX)
> continue;
>
> - drvdata->mi2s_osr_clk[dai_id] = devm_clk_get(dev,
> + drvdata->mi2s_osr_clk[dai_id] = devm_clk_get_optional(dev,
> variant->dai_osr_clk_names[i]);
> - if (IS_ERR(drvdata->mi2s_osr_clk[dai_id])) {
> - dev_warn(dev,
> - "%s() error getting optional %s: %ld\n",
> - __func__,
> - variant->dai_osr_clk_names[i],
> - PTR_ERR(drvdata->mi2s_osr_clk[dai_id]));
> -
> - drvdata->mi2s_osr_clk[dai_id] = NULL;
> - }
> -
> drvdata->mi2s_bit_clk[dai_id] = devm_clk_get(dev,
> variant->dai_bit_clk_names[i]);
> if (IS_ERR(drvdata->mi2s_bit_clk[dai_id])) {
>
> base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5
>
next prev parent reply other threads:[~2021-05-21 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 1:48 Stephen Boyd
2021-05-21 9:34 ` Srinivas Kandagatla [this message]
2021-05-21 15:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96301eb2-ef2d-be7f-2a24-8723c1e39905@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®