From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9461018050 for ; Tue, 26 May 2026 10:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779791089; cv=none; b=tUHaHNuiNpSFI8l504MUVserW7EjxmbaYuhIhzc3UIn/dPqqryJg+lqG0rNvZMLsg+zWSg3+sVpZUwceEPtzTg4SKv3+Ky5OzFirv/dWRBmQZVL6GEDejPZ5DMaNzRs7MSv7dySDcSoExrzgZqlQNr8lfWyJPAUecGNU1BeC0lU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779791089; c=relaxed/simple; bh=CnO0EOLmoB++aXVuPIFILPzmjd9h2ynFiUXi2zEbhys=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kXhlVHZ4NdHicCfMOZe5bl/QyhHR45y7F+ABiNuysZ59FaDv6yjULNJAvBsmehYNJeX+ONvyW6mi1DBG5UsDqPVEhfdRzy4aX+KropAfgIXzQKHMrpzdSeuhCW1w4lguunE0u0Kx6gmxHiz9qQ5mRK7ph1KTR1Kzxr5sRNL9K9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=ndaeLPKr; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="ndaeLPKr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1779791080; bh=CnO0EOLmoB++aXVuPIFILPzmjd9h2ynFiUXi2zEbhys=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ndaeLPKrcqSWNZbF/Zc7ZF9+2/6O75dxc0F4pzEZU6+59hTrlmtu0h+3DMEhAY5OX nLNZQp6J/lYA5KIBaO2Nyoe59e1tqBTJFHL2WWKLciNfAkcWnwcnUyf1pqlZ9SHvop /EHtrY6opgNMBaI/pI+5VeTmXOBzTgr87odeCy162GBaUSA47y/OcIpuqwfD+rlo/+ t5eHWR1I6HPgrwDSbV+s8Ep58tS9Z7f9dyWJjH6htvaIe8GjWNWvzMhFyixN+V82lL 3Kqfkp5iD1aF4zSTmx70fW79n+cat6f8DOKWqkNlUq/aD9DppkfZ9XXnGxk02GAgRZ avuGq5lKgtM7A== Received: from [100.64.1.21] (unknown [100.64.1.21]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 6329417E05B5; Tue, 26 May 2026 12:24:40 +0200 (CEST) Message-ID: <963068ab-6d87-4e5f-b6bc-de1b27b7f621@collabora.com> Date: Tue, 26 May 2026 12:24:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] regulator: mt6363: select CONFIG_IRQ_DOMAIN To: Arnd Bergmann , Liam Girdwood , Mark Brown Cc: Arnd Bergmann , linux-kernel@vger.kernel.org References: <20260526102003.2527570-1-arnd@kernel.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20260526102003.2527570-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/26/26 12:19, Arnd Bergmann wrote: > From: Arnd Bergmann > > When build-testing this driver without CONFIG_IRQ_DOMAIN causes > a compile-time error: > > drivers/regulator/mt6363-regulator.c: In function 'mt6363_regulator_probe': > drivers/regulator/mt6363-regulator.c:884:18: error: implicit declaration of function 'irq_find_host' [-Wimplicit-function-declaration] > 884 | domain = irq_find_host(interrupt_parent); > | ^~~~~~~~~~~~~ > drivers/regulator/mt6363-regulator.c:884:16: error: assignment to 'struct irq_domain *' from 'int' makes pointer from integer without a cast [-Wint-conversion] > 884 | domain = irq_find_host(interrupt_parent); > | ^ > drivers/regulator/mt6363-regulator.c:896:30: error: implicit declaration of function 'irq_create_fwspec_mapping'; did you mean 'irq_create_of_mapping'? [-Wimplicit-function-declaration] > 896 | info->virq = irq_create_fwspec_mapping(&fwspec); > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > | irq_create_of_mapping > > This is rather hard to trigger because so many other drivers > enable IRQ_DOMAIN already, but I ran into this on an s390 > randconfig build. > > Ensure this is always enabled using a Kconfig 'select IRQ_DOMAIN' > entry, as we do for all other users of this. > > Fixes: 3c36965df808 ("regulator: Add support for MediaTek MT6363 SPMI PMIC Regulators") > Signed-off-by: Arnd Bergmann Reviewed-by: AngeloGioacchino Del Regno