From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3759C433E1 for ; Wed, 26 Aug 2020 15:44:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB6582078A for ; Wed, 26 Aug 2020 15:44:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727968AbgHZPon (ORCPT ); Wed, 26 Aug 2020 11:44:43 -0400 Received: from smtprelay0028.hostedemail.com ([216.40.44.28]:36062 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726739AbgHZPog (ORCPT ); Wed, 26 Aug 2020 11:44:36 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 57C931DF9; Wed, 26 Aug 2020 15:44:33 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: knot54_5a184f527065 X-Filterd-Recvd-Size: 2176 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Wed, 26 Aug 2020 15:44:32 +0000 (UTC) Message-ID: <9635eaa4ccc1141fb0dd8c3687f46da7149206ad.camel@perches.com> Subject: Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check From: Joe Perches To: Andy Shevchenko , Andrzej Hajda , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J . Wysocki" Date: Wed, 26 Aug 2020 08:44:30 -0700 In-Reply-To: <20200826104459.81979-1-andriy.shevchenko@linux.intel.com> References: <20200826104459.81979-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-08-26 at 13:44 +0300, Andy Shevchenko wrote: > We have got already new users of this API which interpret it differently > and miss the opportunity to optimize their code. > > In order to avoid similar cases in the future, annotate dev_err_probe() > with __must_check. > > Fixes: a787e5400a1c ("driver core: add device probe log helper") > Signed-off-by: Andy Shevchenko > --- > include/linux/device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/device.h b/include/linux/device.h > index ca18da4768e3..f9d2e5703bbf 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -978,7 +978,7 @@ void device_links_supplier_sync_state_pause(void); > void device_links_supplier_sync_state_resume(void); > > extern __printf(3, 4) > -int dev_err_probe(const struct device *dev, int err, const char *fmt, ...); > +int __must_check dev_err_probe(const struct device *dev, int err, const char *fmt, ...); Generally, the __must_check should go before the return type and the extern isn't necessary and is also generally not used in device.h, so I'd prefer: __printf(3, 4) __must_check int dev_err_probe(...);