From: "André Draszik" <andre.draszik@linaro.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Lee Jones <lee@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 06/17] dt-bindings: firmware: google,gs101-acpm-ipc: update PMIC examples
Date: Wed, 04 Jun 2025 16:26:50 +0100 [thread overview]
Message-ID: <963bbf8db71efc0d729bb9141c133df2c56881fc.camel@linaro.org> (raw)
In-Reply-To: <20250604-s2mpg1x-regulators-v1-6-6038740f49ae@linaro.org>
On Wed, 2025-06-04 at 16:25 +0100, André Draszik wrote:
> In a typical system using the Samsung S2MPG10 PMIC, an S2MPG11 is used
> as a sub-PMIC.
>
> The interface for both is the ACPM firmware protocol, so update the
> example here to describe the connection for both.
>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> .../bindings/firmware/google,gs101-acpm-ipc.yaml | 40 ++++++++++++++++++++--
> 1 file changed, 37 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml
> b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml
> index 62a3a7dac5bd250a7f216c72f3315cd9632d93e1..408cf84e426b80b6c06e69fda87d0f8bfc61498d 100644
> --- a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml
> +++ b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml
> @@ -36,6 +36,15 @@ properties:
> compatible:
> const: samsung,s2mpg10-pmic
>
> + pmic2:
> + description: Child node describing the sub PMIC.
> + type: object
> + additionalProperties: true
> +
> + properties:
> + compatible:
> + const: samsung,s2mpg11-pmic
> +
Since we have two PMICs here, but can not use the 'reg' property (as the
addressing is based on software, i.e. the ACPM firmware), I've opted
for 'pmic' (existing) and 'pmic2' (new) as nodenames.
Maybe 'pmic-main' and 'pmic-sub' would be more appropriate, but 'pmic' is a
bit more standard I believe. I'm open for better suggestions :-)
Cheers,
Andre'
next prev parent reply other threads:[~2025-06-04 15:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 15:25 [PATCH 00/17] Samsung S2MPG10 regulator and S2MPG11 PMIC drivers André Draszik
2025-06-04 15:25 ` [PATCH 01/17] dt-bindings: firmware: google,gs101-acpm-ipc: convert regulators to lowercase André Draszik
2025-06-04 15:25 ` [PATCH 02/17] regulator: dt-bindings: add s2mpg10-pmic regulators André Draszik
2025-06-04 15:25 ` [PATCH 03/17] regulator: dt-bindings: add s2mpg11-pmic regulators André Draszik
2025-06-04 15:25 ` [PATCH 04/17] dt-bindings: mfd: samsung,s2mps11: add s2mpg10-pmic regulators André Draszik
2025-06-04 15:25 ` [PATCH 05/17] dt-bindings: mfd: samsung,s2mps11: add s2mpg11-pmic André Draszik
2025-06-04 15:25 ` [PATCH 06/17] dt-bindings: firmware: google,gs101-acpm-ipc: update PMIC examples André Draszik
2025-06-04 15:26 ` André Draszik [this message]
2025-06-04 15:25 ` [PATCH 07/17] mfd: sec-common: Instantiate s2mpg10 bucks and ldos separately André Draszik
2025-06-13 14:19 ` Lee Jones
2025-06-13 14:49 ` André Draszik
2025-06-13 14:52 ` André Draszik
2025-06-25 15:12 ` André Draszik
2025-06-04 15:25 ` [PATCH 08/17] mfd: sec: Add support for S2MPG11 PMIC via ACPM André Draszik
2025-06-13 14:22 ` Lee Jones
2025-06-04 15:25 ` [PATCH 09/17] regulator: s2mps11: drop two needless variable initialisations André Draszik
2025-06-04 15:25 ` [PATCH 10/17] regulator: s2mps11: use dev_err_probe() where appropriate André Draszik
2025-06-04 15:25 ` [PATCH 11/17] regulator: s2mps11: update node parsing (allow -supply properties) André Draszik
2025-06-04 15:25 ` [PATCH 12/17] regulator: s2mps11: refactor handling of external rail control André Draszik
2025-06-04 15:25 ` [PATCH 13/17] regulator: s2mps11: add S2MPG10 regulator André Draszik
2025-06-04 15:25 ` [PATCH 14/17] regulator: s2mps11: refactor S2MPG10 ::set_voltage_time() for S2MPG11 reuse André Draszik
2025-06-04 15:25 ` [PATCH 15/17] regulator: s2mps11: refactor S2MPG10 regulator macros " André Draszik
2025-06-04 15:25 ` [PATCH 16/17] regulator: s2mps11: add S2MPG11 regulator André Draszik
2025-06-04 15:25 ` [PATCH 17/17] regulator: s2mps11: more descriptive gpio consumer name André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=963bbf8db71efc0d729bb9141c133df2c56881fc.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®