From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751412AbdBOOYJ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Feb 2017 09:24:09 -0500
Received: from mail-pg0-f68.google.com ([74.125.83.68]:34873 "EHLO
        mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751022AbdBOOYH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Feb 2017 09:24:07 -0500
Subject: Re: [Suggestion/Problems] perf annoate: Some problems related to the
 source code view and Improvement of it with line numbers
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
References: <5c703d64-3ef4-3d43-bf99-f14c5fc4cdac@gmail.com>
 <20170215132411.GF4020@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
        perf group <linux-perf-users@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
From: Taeung Song <treeze.taeung@gmail.com>
Message-ID: <963c309b-ca3a-e5a7-30f3-e0a521e5c3e5@gmail.com>
Date: Wed, 15 Feb 2017 23:24:01 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20170215132411.GF4020@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 02/15/2017 10:24 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Feb 15, 2017 at 09:34:51PM +0900, Taeung Song escreveu:
>> > Hi all :)
>> >
>> > I found some problems about showing line numbers of perf-annotate.
>> > and I have a suggestion about perf-annotate.
>> >
>> > Sure, I have a plan to send the patchset about that.
>> > But I'd like to know other opinions about that before sending the patchset.
>> > :)
> Humm, TLDR, please try to find one problem, describe it precisely, show
> before and after results (in the changeset message), and send it, rinse,
> repeat.
>
> For instance, if the line numbers are different in --stdio and --tui,
> that is a problem, state that, show the output (as you did below), put
> it in a patch, send it.
>

Okey it was too long.

I'll separate the contents into simple parts
and send a patch with things you said :)
for easy review.

Thanks,
Taeung