Re: [v2 PATCH 0/7] Add AMD8111 and AMD8131 EDAC drivers

[Doug Thompson <norsk5@yahoo.com>]

--- On Tue, 3/10/09, Harry Ciao <qingtao.cao@windriver.com> wrote:

> From: Harry Ciao <qingtao.cao@windriver.com>
> Subject: [v2 PATCH 0/7] Add AMD8111 and AMD8131 EDAC drivers
> To: linux-kernel@vger.kernel.org, bluesmoke-devel@lists.sourceforge.net
> Date: Tuesday, March 10, 2009, 9:25 PM
> 
> Hi,
> 
> This is the v2 series of patches for EDAC AMD8111 &
> AMD8131 drivers.
> I have integrated suggestions from Bert, Greg and Andrew.
> Tests all passed on Maple platform, these modules could be
> properly
> loaded/unloaded, with their sysfs interfaces
> created/cleaned.
> 
> Any suggestions are warmly welcomed!
> 
> Best regards,
> 
> Harry
> 
> 
> Comments:        
> ---------
> Introduce AMD8111 EDAC driver, which makes use of error
> detections 
> on the LPC Bridge Controller and PCI Bridge Controller on
> the AMD8111 
> HyperTransport I/O Hub.
> 
> Introduce AMD8131 EDAC driver source file, which makes use
> of error
> detections on the PCI-X Bridge Controllers on the AMD8131
> HyperTransport
> PCI-X Tunnel.
> 
> Since both AMD8111 and AMD8131 EDAC drivers would use
> edac_pci_ctl_info
> structures, EDAC core has to take the responsibility to
> allocate a unique
> "edac_pci_idx" for each of them, by newly added
> edac_pci_alloc_index().
> 
> Note, by far only POLL mode is supported, and they have
> been tested on 
> MAPLE platform, from below test logs we can tell that they
> could be 
> correctly installed and removed, and export proper sysfs
> interfaces.

harry,

thanks for the new edac_pci_alloc_index(). I have been meaning to solve that issue for sometime, but didn't have a pressing need to do so. You brought one and solved it.

thanks again

doug t