From: SF Markus Elfring <elfring@users.sourceforge.net>
To: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
Bart Van Assche <bart.vanassche@sandisk.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 5/6] target: tcm_loop: Delete an unnecessary return statement in tcm_loop_submission_work()
Date: Mon, 11 Dec 2017 11:46:51 +0100 [thread overview]
Message-ID: <9643f835-78e6-51cc-3d07-7a43a3c5eb07@users.sourceforge.net> (raw)
In-Reply-To: <42f13f0c-ae1d-ec1e-fd9d-62dd15aeba8c@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 11 Dec 2017 10:58:33 +0100
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/target/loopback/tcm_loop.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c
index 08dbf5b4ff15..ec01070bbb40 100644
--- a/drivers/target/loopback/tcm_loop.c
+++ b/drivers/target/loopback/tcm_loop.c
@@ -166,7 +166,6 @@ static void tcm_loop_submission_work(struct work_struct *work)
out_done:
kmem_cache_free(tcm_loop_cmd_cache, tl_cmd);
sc->scsi_done(sc);
- return;
}
/*
--
2.15.1
next prev parent reply other threads:[~2017-12-11 10:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 10:40 [PATCH 0/6] target/loopback/tcm: Adjustments for some function implementations SF Markus Elfring
2017-12-11 10:42 ` [PATCH 1/6] target: tcm_loop: Delete an error message for a failed memory allocation in four functions SF Markus Elfring
2017-12-11 10:43 ` [PATCH 2/6] target: tcm_loop: Improve a size determination in two functions SF Markus Elfring
2017-12-11 10:44 ` [PATCH 3/6] target: tcm_loop: Combine substrings for 26 messages SF Markus Elfring
2017-12-11 10:45 ` [PATCH 4/6] target: tcm_loop: Delete two unnecessary variable initialisations in tcm_loop_issue_tmr() SF Markus Elfring
2017-12-11 10:46 ` SF Markus Elfring [this message]
2017-12-11 10:48 ` [PATCH 6/6] target: tcm_loop: Use seq_puts() in tcm_loop_show_info() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9643f835-78e6-51cc-3d07-7a43a3c5eb07@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=bart.vanassche@sandisk.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome