From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A06FC433EF for ; Thu, 12 May 2022 05:58:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350058AbiELF6G (ORCPT ); Thu, 12 May 2022 01:58:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245288AbiELF6D (ORCPT ); Thu, 12 May 2022 01:58:03 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EB3F21A97D; Wed, 11 May 2022 22:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1652335081; x=1683871081; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=NZnDnpvgn5my4A1DvCZcio68+0nCB9EOlvfdWJyoVwM=; b=uaN6etRChmtAK0UDuMe2evnLmOnyeKLErk9PA17i15vm40hyTVueYf2w bK3K+KrZfIiOJNc/PupvPOW6JTFP1kWEn6SGspAc+sj7Eif3jTPHsI+3E MeW75yaUMsPBVCYydGI47t7SiRU2zEmWzjO2cnUvnETWEmpYoiuJ4nj6n M=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-02.qualcomm.com with ESMTP; 11 May 2022 22:58:01 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 22:58:00 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 11 May 2022 22:58:00 -0700 Received: from [10.216.61.198] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 11 May 2022 22:57:53 -0700 Message-ID: <9644d608-4ab9-ed0d-50fb-0016e4331361@quicinc.com> Date: Thu, 12 May 2022 11:27:48 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [v4 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings Content-Language: en-US To: Krzysztof Kozlowski , Krzysztof Kozlowski , Rob Herring , "Andy Gross" , Bjorn Andersson , Greg Kroah-Hartman , Stephen Boyd , Doug Anderson , "Matthias Kaehlcke" , Wesley Cheng , "Vinod Koul" CC: , , , , , , , , Sandeep Maheswaram References: <1652282793-5580-1-git-send-email-quic_kriskura@quicinc.com> <1652282793-5580-2-git-send-email-quic_kriskura@quicinc.com> From: Krishna Kurapati PSSNV In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/11/2022 11:49 PM, Krzysztof Kozlowski wrote: > On 11/05/2022 17:26, Krishna Kurapati wrote: >> From: Sandeep Maheswaram >> >> Add device tree bindings for SNPS phy tuning parameters. >> >> Signed-off-by: Sandeep Maheswaram >> Signed-off-by: Krishna Kurapati >> --- >> .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 87 ++++++++++++++++++++++ >> 1 file changed, 87 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml >> index 1ce251d..70efffe 100644 >> --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml >> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml >> @@ -53,6 +53,93 @@ properties: >> vdda33-supply: >> description: phandle to the regulator 3.3V supply node. >> >> + qcom,hs-disconnect-bps: >> + $ref: /schemas/types.yaml#/definitions/int32 >> + description: >> + This adjusts the voltage level for the threshold used to >> + detect a disconnect event at the host. Possible values are. >> + The values defined are in multiples of basis points (1bp = 0.01%). > This means there is some minimum and maximum (100%)? Hi Krzystof, Yes there are max and min for each parameter (not necessarily 0%/100%) As an example if we take squelch detector threshold, the register value vs actual percentage changer as per data book is as follows : % change in voltage    |     corresponding reg value  -20.90%                        |    7  -15.60%                        |    6 -10.30%                         |    5 -5.30%                           |    4 0%                                  |    3 5.30%                            |    2 10.60%                          |    1 15.90%                          |    0 Here the min and max are 15.9% to -20.9% The min and max differ for each parameter and might not be necessarily 0% and 100% >> + The hardware accepts only discrete values. The value closest to the >> + provided input will be chosen as the override value for this param. >> + >> + qcom,squelch-detector-bps: >> + $ref: /schemas/types.yaml#/definitions/int32 >> + description: >> + This adjusts the voltage level for the threshold used to >> + detect valid high-speed data. >> + The values defined are in multiples of basis points (1bp = 0.01%). >> + The hardware accepts only discrete values. The value closest to the >> + provided input will be chosen as the override value for this param. >> + >> + qcom,hs-amplitude-bps: >> + $ref: /schemas/types.yaml#/definitions/int32 >> + description: >> + This adjusts the high-speed DC level voltage. >> + The values defined are in multiples of basis points (1bp = 0.01%). >> + The hardware accepts only discrete values. The value closest to the >> + provided input will be chosen as the override value for this param. >> + >> + qcom,pre-emphasis-duration-bps: >> + $ref: /schemas/types.yaml#/definitions/int32 >> + description: >> + This signal controls the duration for which the >> + HS pre-emphasis current is sourced onto DP<#> or DM<#>. >> + The HS Transmitter pre-emphasis duration is defined in terms of >> + unit amounts. One unit of pre-emphasis duration is approximately >> + 650 ps and is defined as 1X pre-emphasis duration. >> + The values defined are in multiples of basis points (1bp = 0.01%). >> + The hardware accepts only discrete values. The value closest to the >> + provided input will be chosen as the override value for this param. >> + >> + qcom,pre-emphasis-amplitude-bps: >> + $ref: /schemas/types.yaml#/definitions/int32 >> + description: >> + This signal controls the amount of current sourced to >> + DP<#> and DM<#> after a J-to-K or K-to-J transition. >> + The HS Transmitter pre-emphasis current is defined in terms of unit >> + amounts. One unit amount is approximately 2 mA and is defined as >> + 1X pre-emphasis current. >> + The values defined are in multiples of basis points (1bp = 0.01%). >> + The hardware accepts only discrete values. The value closest to the >> + provided input will be chosen as the override value for this param. >> + >> + qcom,hs-rise-fall-time-bps: >> + $ref: /schemas/types.yaml#/definitions/int32 >> + description: >> + This adjusts the rise/fall times of the high-speed waveform. >> + The values defined are in multiples of basis points (1bp = 0.01%). >> + The hardware accepts only discrete values. The value closest to the >> + provided input will be chosen as the override value for this param. >> + >> + qcom,hs-crossover-voltage-mv: >> + $ref: /schemas/types.yaml#/definitions/int32 >> + description: >> + This adjusts the voltage at which the DP<#> and DM<#> >> + signals cross while transmitting in HS mode. >> + The values defined are in milli volts. The hardware accepts only >> + discrete values. The value closest to the provided input will be >> + chosen as the override value for this param. >> + >> + qcom,hs-output-impedance-mohm: >> + $ref: /schemas/types.yaml#/definitions/int32 > Here and in other places, please use standard units. See > dtschema/schemas/property-units.yaml in dtschema repo. > > > Best regards, > Krzysztof