From: Jan Stancek <jstancek@redhat.com>
To: Megha Dey <megha.dey@intel.com>
Cc: herbert@gondor.apana.org.au,
tim c chen <tim.c.chen@linux.intel.com>,
davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org,
ilya albrekht <ilya.albrekht@intel.com>
Subject: Re: [Patch V3] crypto: x86/sha1 : Fix reads beyond the number of blocks passed
Date: Wed, 2 Aug 2017 15:18:50 -0400 (EDT) [thread overview]
Message-ID: <964539021.65400093.1501701530053.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1501698918.9349.1.camel@megha-Z97X-UD7-TH>
----- Original Message -----
> On Wed, 2017-08-02 at 10:13 -0700, Megha Dey wrote:
> > It was reported that the sha1 AVX2 function(sha1_transform_avx2) is
> > reading ahead beyond its intended data, and causing a crash if the next
> > block is beyond page boundary:
> > http://marc.info/?l=linux-crypto-vger&m=149373371023377
> >
> > This patch makes sure that there is no overflow for any buffer length.
> >
> > It passes the tests written by Jan Stancek that revealed this problem:
> > https://github.com/jstancek/sha1-avx2-crash
>
> Hi Jan,
>
> Is it ok to add your Tested-by?
Yes, v3 patch is exactly the diff I was testing.
Regards,
Jan
prev parent reply other threads:[~2017-08-02 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 17:13 Megha Dey
2017-08-02 18:35 ` Megha Dey
2017-08-02 19:18 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=964539021.65400093.1501701530053.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=ilya.albrekht@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megha.dey@intel.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome