From: "David Hildenbrand (Arm)" <david@kernel.org>
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>, shao.mingyin@zte.com.cn
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/balloon: fix NR_BALLOON_PAGES accounting on migration failure
Date: Fri, 20 Nov 2026 10:59:47 +0100 [thread overview]
Message-ID: <96462da9-9437-4774-a5c7-f99858481ece@kernel.org> (raw)
In-Reply-To: <avia_XgVOuN_pZ72@gremlin>
On 11/14/26 18:31, Lorenzo Stoakes (ARM) wrote:
> On Sun, Nov 15, 2026 at 12:47:08AM +0800, shao.mingyin@zte.com.cn wrote:
>> From: Shao Mingyin <shao.mingyin@zte.com.cn>
>>
>> mm/balloon: fix NR_BALLOON_PAGES accounting on migration failure
>>
>> A balloon driver's -ENOENT migration result means that the old page was
>> deflated but the replacement was not inflated. vmw_balloon returns this
>> when its deflate operation succeeds and the subsequent inflate fails.
>>
>> balloon_page_migrate() accounts the deflation and frees the old page,
>> but does not decrement NR_BALLOON_PAGES. Each such failure therefore
>> leaves one extra page in the per-node count, which also contributes to
>> the Balloon value in /proc/meminfo.
>>
>> Decrement the counter on the old page's node, matching normal dequeue
>> accounting.
>>
>> Fixes: 4d689474e1b2 ("balloon_compaction: update the NR_BALLOON_PAGES state")
>> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
>
> NAK.
>
> this is generated by some AI slopper's script, spamming the kernel. The
> patches I looked at were wrong/broken, so no to anything from this person.
>
> They've sent 300 mails in under four weeks spanniing: ata, scsi, target,
> ufs, nvme/nvmet, ubifs, ublk, zloop, dm, md, mmc, virtio-blk, mfd, gpio,
> pwm, spi, PCI, ASoC, ACPI, net, vfs mount, block partitions, and now mm.
>
> and 17 series across 7 subsystems over the past 23 hours.
>
> We need a way to ban emails from people like this...
Yeah, that's absolutely annoying. In particular as we REQUIRE people to
understand the changes they submit, and own the code.
That clearly won't happen in this case.
There is a real (low prio) bug hiding in there, so something to be fixed. I'll
take care of it.
I'll take care of it.
--
Cheers,
David
next prev parent reply other threads:[~2026-11-20 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 16:47 shao.mingyin
2026-11-14 17:31 ` Lorenzo Stoakes (ARM)
2026-11-20 9:59 ` David Hildenbrand (Arm) [this message]
2026-11-20 10:36 ` Lorenzo Stoakes (ARM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96462da9-9437-4774-a5c7-f99858481ece@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=shao.mingyin@zte.com.cn \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®