From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EBB43988FD for ; Tue, 17 Mar 2026 22:21:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773786070; cv=none; b=VuuM9OSWDwp65W2G/Q6kdiOSPLfq41x3JHpQsd3rQ5BIO/CgPgdaClLc9Ts7Fx5uiXDNzNqlr9J1wb0QE35YZKjnhB+8Pi/cstiruu+8i7KIieNdo2RMf/GOnBfssXOz1O3CK1vUV4VZLZgl9cALwXxXveXIup1GgxJXCKRmsUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773786070; c=relaxed/simple; bh=0Uv5d+5bbxOiBwF6M/B3VboB0yLE4Kxcf8RxYCwaTRc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BSMW6aMBAcw5EsO1cMwwdO3hBsEJ7yFsY7qJ6VaApvHKrzwnotjZT1Pf0kdc5h1X8cwM9AHnN+/RKn5Agix3XLUhtjMZbtGYP6MIp5bh3nLzS2jYA3fX6KqXEE4jY9v0Ukyqp46/18V/yueACu34wf9VK85qYATtY5xCqS9bWcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F7AB7s4g; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F7AB7s4g" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso7508969eec.1 for ; Tue, 17 Mar 2026 15:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773786068; x=1774390868; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=WuptZXzFK4L2PdpOl2b489CN0eHGzhpdwJXoMDn53BA=; b=F7AB7s4gJVImSXktvFOgLyIwzHGk0B5R7JerD7UQh+Qo9e6yZ4v39A12FEgpMq1GMm mBkTVbd2RkMc58UKVyCQot/hS9sFerfbfsAy2jFEMmkrY3jRBpc5WpoWYGXlAmqbSWqv yquWa+xpctIe2CJOgFFOPXeeA8KeFqS4SzFSJt7Synzrbl2BNp6Gf8zI2Pt/r4mEv2VU YmZH9u1mweVrf8d86q359Dy6D0pq7Ti8q5fJi3rDNwpaihQSNLD0H31CVlGaM9TDe4ps rRit7AmPKOT2Cn2R2eZF8yklcLl5ep26nlo2Y16QsSZSd4ROfptXlaB1LT+fop5CSnZ3 RXXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773786068; x=1774390868; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WuptZXzFK4L2PdpOl2b489CN0eHGzhpdwJXoMDn53BA=; b=TMAJh7oak14xEPHUC6JTRf4E/6SLqvA0MafJ8EbBuWJUaQ4fNQOsoKXJqoFOSZdZIq d5gWrOUP6BC1JpRTO3n9qTfLT7PwL2K4a26DVQDI/mBaDU1EcVbF4dEJaLWPdvFRqG7+ Q7JXuED7ioz6Uie83L6T40pnC1B40wJMdyzXBZMXaAzMiHW+x/HpYE74IdLwlKJ6ObAL FT4HQ56WOXq44uOR4IujQWV29rpfJhF6k1os2lsaXhTTmYwsdJ5hZHhD7EI4khAE2TBL YQyNJxl5p/qQWm6MIh6TC27/2HO5mz3SzAdu5PchbHQzIN+ZDZKsnzQyXNHBtwwpdlcM WwHA== X-Forwarded-Encrypted: i=1; AJvYcCUOzZ7bJS2eWwx+ksY8+XV5zU+fbWHB/9svOY2II53PNPkGcPzg0f4OkaHVifC7TYsw6aHJsBIkumg9FVU=@vger.kernel.org X-Gm-Message-State: AOJu0YwXhmXMwI61pcWuneMpBq0L80+QzZG49X0w5tSJLRvXruEnYkcG Sekk+4ZEukSQf76X2LSFCrVDW/0/i4InGAhbNg/3KgYwkPxe6ptbUFHU X-Gm-Gg: ATEYQzyfwmlcAMQcQ2poDTUv+Tq23okbTBLH7yMFywWFfEcg/tC36y6V9v8X4jHVlsj 77Yqlkmf/EgtvTnCitrtJlo8XE+5k/5HF8x5GiB1dkSs58ZGRIU3VPL9zdCihxy2Ph6ab3WRuq3 nhxGQAmwhntEFOnJzm/35w4kvoKTGjTE3Vr4Lyn4F15V91Byqeo1eHk3fXbDwSFwpbp3hNE+1Ov iv/eNxcGobU9o6cjxxjPwCVIw9qkGAAI3KXbFe3vg7RvQ0AtPbFFAzV4pJwcirlutOTTixvhHSi ahDVp6OfoP2saHw7fBl7ErQPDRlRXrnGyVzlAQ/2K/oKHuSjWf1vzpeA6coBoNwu1f3v7LXMZmf FrjQYaeJpDFC9fe3/UWPVsorUkQuCWpWAdD0wEdkPuCwsHIFapOWkO+rY3wS77PwxOP/u7eKJhw LLFpCyNqm9odxUkkWKN0xzp+Rc0MWWkSctYqozMUh2PDvRhaM= X-Received: by 2002:a05:7300:cb0b:b0:2b7:19f2:6b70 with SMTP id 5a478bee46e88-2c0e51be9abmr465026eec.26.1773786068215; Tue, 17 Mar 2026 15:21:08 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e55a2be4sm1414926eec.22.2026.03.17.15.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 15:21:07 -0700 (PDT) Sender: Guenter Roeck Date: Tue, 17 Mar 2026 15:21:07 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: "linux-hwmon@vger.kernel.org" , "vasileios.amoiridis@cern.ch" , "leo.yang.sy0@gmail.com" , "wensheng@yeah.net" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: Re: [PATCH 3/5] hwmon: (pmbus/mp2869) Check pmbus_read_byte_data() before using its return value Message-ID: <964686d5-a9d1-4db4-be24-81b48a0db3bd@roeck-us.net> References: <20260317173308.382545-1-sanman.pradhan@hpe.com> <20260317173308.382545-4-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260317173308.382545-4-sanman.pradhan@hpe.com> On Tue, Mar 17, 2026 at 05:37:41PM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan > > In mp2869_read_byte_data() and mp2869_read_word_data(), the return value > of pmbus_read_byte_data() for PMBUS_STATUS_MFR_SPECIFIC is used directly > inside FIELD_GET() macro arguments without error checking. If the I2C > transaction fails, a negative error code is passed to FIELD_GET() and > FIELD_PREP(), silently corrupting the status register bits being > constructed. > > Extract the nested pmbus_read_byte_data() calls into a separate variable > and check for errors before use. This also eliminates a redundant duplicate > read of the same register in the PMBUS_STATUS_TEMPERATURE case. > > Fixes: a3a2923aaf7f2 ("hwmon: add MP2869,MP29608,MP29612 and MP29816 series driver") > Cc: stable@vger.kernel.org > Signed-off-by: Sanman Pradhan Applied. Thanks, Guenter