From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEEB2C433F5 for ; Thu, 28 Apr 2022 18:41:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351208AbiD1Sot (ORCPT ); Thu, 28 Apr 2022 14:44:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351204AbiD1Soq (ORCPT ); Thu, 28 Apr 2022 14:44:46 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 576F466F99 for ; Thu, 28 Apr 2022 11:41:31 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 1DB581F45BA9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651171290; bh=HSr1KCZ5LnslRjGdE29dDFgwDJWDw5RpI+XCM1ThDIE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bfLldcJ+mxw6WfTtItLTOjLcjf0DYyzsn4duwT4V65y2wh/auNP5VbaKcF1uLtb0B iB/cky4I5BR35dO0sBsMH/IMcS2hQcrcukVUN2Se+PPS1Acf+cYw0aWDojUZPfuPr6 lry0gDJpMS6Znk7q4EgkKajPlWGFIbW3IQSsLO06kQYS5k5BW2+iwu3TyC1kW+eE2T ltrTAD36FgqZAog2GI8KGWD5k8oX5TmtV/lGfBCUjyzIl3wf69EgFqlvTSr7MWV/Rl O+vG2kloLrPb0rbCPCkO+207H8MSE6C8OYDbpOG/crx11Q8yVrBAc1ev3YHC1FTzVZ Ke2HvHpsR9S0A== Message-ID: <9647245d-b0b5-12d1-fef2-7a5f759f908b@collabora.com> Date: Thu, 28 Apr 2022 21:41:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 01/17] drm/panfrost: Put mapping instead of shmem obj on panfrost_mmu_map_fault_addr() error Content-Language: en-US To: Steven Price , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Daniel Almeida , Gert Wollny , Gustavo Padovan , Daniel Stone , Tomeu Vizoso , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Alyssa Rosenzweig , Rob Clark , Emil Velikov , Robin Murphy , Qiang Yu , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Dmitry Osipenko References: <20220424190424.540501-1-dmitry.osipenko@collabora.com> <20220424190424.540501-2-dmitry.osipenko@collabora.com> <37dae9fa-dadf-4b80-fbea-689472fd7dce@arm.com> From: Dmitry Osipenko In-Reply-To: <37dae9fa-dadf-4b80-fbea-689472fd7dce@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 28.04.2022 16:19, Steven Price пишет: > On 24/04/2022 20:04, Dmitry Osipenko wrote: >> When panfrost_mmu_map_fault_addr() fails, the BO's mapping should be >> unreferenced and not the shmem object that backs that mapping. >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Dmitry Osipenko > > Fixes: bdefca2d8dc0 ("drm/panfrost: Add the panfrost_gem_mapping concept") > > Reviewed-by: Steven Price Thank you for the fixes tag. It appeared to me that this problem existed since the first addition of the srinker when I was looking up the offending commit, my bad :)