From: David Hildenbrand <david@redhat.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc: Modify the comment section for alloc_contig_pages()
Date: Thu, 16 Dec 2021 11:59:34 +0100 [thread overview]
Message-ID: <9652ae2a-2b40-36f9-4668-4c0cbd89862d@redhat.com> (raw)
In-Reply-To: <1639545478-12160-1-git-send-email-anshuman.khandual@arm.com>
On 15.12.21 06:17, Anshuman Khandual wrote:
> Just clarify, that the alloc_contig_pages() allocated range will always be
> aligned to the requested nr_pages.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> mm/page_alloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index c5952749ad40..0d74ea524dd4 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -9214,8 +9214,8 @@ static bool zone_spans_last_pfn(const struct zone *zone,
> * for allocation requests which can not be fulfilled with the buddy allocator.
> *
> * The allocated memory is always aligned to a page boundary. If nr_pages is a
> - * power of two then the alignment is guaranteed to be to the given nr_pages
> - * (e.g. 1GB request would be aligned to 1GB).
> + * power of two, then allocated range is also guaranteed to be aligned to same
> + * nr_pages (e.g. 1GB request would be aligned to 1GB).
> *
> * Allocated pages can be freed with free_contig_range() or by manually calling
> * __free_page() on each allocated page.
>
To me new vs. old express exactly the same. But it might be an
improvement so I won't object :)
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-12-16 10:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 5:17 Anshuman Khandual
2021-12-16 10:59 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9652ae2a-2b40-36f9-4668-4c0cbd89862d@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®