From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D541C54EE9 for ; Wed, 7 Sep 2022 14:55:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229776AbiIGOzy (ORCPT ); Wed, 7 Sep 2022 10:55:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229893AbiIGOz2 (ORCPT ); Wed, 7 Sep 2022 10:55:28 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6E4587FFA7 for ; Wed, 7 Sep 2022 07:55:00 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 28FC6106F; Wed, 7 Sep 2022 07:55:06 -0700 (PDT) Received: from [10.57.15.197] (unknown [10.57.15.197]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A5A7E3F71A; Wed, 7 Sep 2022 07:54:58 -0700 (PDT) Message-ID: <9656a09c-09e9-0c9b-ede6-1d3ddc905e08@arm.com> Date: Wed, 7 Sep 2022 15:54:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] drm/amdgpu: fix repeated words in comments Content-Language: en-GB To: Jilin Yuan , airlied@linux.ie, daniel@ffwll.ch, shaoyun.liu@amd.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20220907113400.30590-1-yuanjilin@cdjrlc.com> From: Robin Murphy In-Reply-To: <20220907113400.30590-1-yuanjilin@cdjrlc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-09-07 12:34, Jilin Yuan wrote: > Delete the redundant word 'and'. > Delete the redundant word 'in'. > Delete the redundant word 'the'. > Delete the redundant word 'are'. > > Signed-off-by: Jilin Yuan > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index afaa1056e039..71367b9dd590 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -958,7 +958,7 @@ static void amdgpu_device_vram_scratch_fini(struct amdgpu_device *adev) > * @registers: pointer to the register array > * @array_size: size of the register array > * > - * Programs an array or registers with and and or masks. Not redundant - the first "and" refers to the boolean operation, the second is a conjunction. This is clear from the code if you look at it. You could perhaps restyle the comment as "with AND and OR masks" to make that stand out a bit better, but either way, please try to actually understand the changes you're proposing. Robin. > + * Programs an array or registers with and or masks. > * This is a helper for setting golden registers. > */ > void amdgpu_device_program_register_sequence(struct amdgpu_device *adev, > @@ -1569,7 +1569,7 @@ static int amdgpu_device_check_arguments(struct amdgpu_device *adev) > * @state: vga_switcheroo state > * > * Callback for the switcheroo driver. Suspends or resumes the > - * the asics before or after it is powered up using ACPI methods. > + * asics before or after it is powered up using ACPI methods. > */ > static void amdgpu_switcheroo_set_state(struct pci_dev *pdev, > enum vga_switcheroo_state state) > @@ -3203,7 +3203,7 @@ static int amdgpu_device_ip_resume_phase2(struct amdgpu_device *adev) > * > * Main resume function for hardware IPs. The hardware IPs > * are split into two resume functions because they are > - * are also used in in recovering from a GPU reset and some additional > + * also used in recovering from a GPU reset and some additional > * steps need to be take between them. In this case (S3/S4) they are > * run sequentially. > * Returns 0 on success, negative error code on failure.