mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chang S. Bae" <chang.seok.bae@intel.com>
To: Guixiong Wei <weiguixiong@bytedance.com>, <x86@kernel.org>
Cc: <tglx@kernel.org>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>, <hpa@zytor.com>,
	<shuah@kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v3 0/2] x86/fpu: Fix dynamic fpstate leak on exec()
Date: Thu, 29 Oct 2026 13:15:55 -0700	[thread overview]
Message-ID: <9657346b-95be-4360-80ff-328bcf29d2b3@intel.com> (raw)
In-Reply-To: <cover.1793072271.git.weiguixiong@bytedance.com>

On 10/26/2026 8:44 PM, Guixiong Wei wrote:
> 
> - Add a pipe-synchronised pre-flight check that confirms the dynamic
>    allocation is observable via /proc/vmallocinfo before measuring the
>    post-exec() delta. Without that gate "no new entries" is ambiguous
>    between "freed" and "never observed" and would silently PASS on
>    kernels where the allocation is not reachable. /proc/vmallocinfo is
>    the only user-visible signal for a leaked post-exec() fpstate (it
>    has no task scope once the task is gone).

I can see the reason for the update, but the change looks a bit 
complicated. Not saying that change is unnecessary, but I wonder whether 
it can be simplified or not.

That said, let's close the Sashiko comment on patch1 first.

BTW, it looks like this series was posted twice. Please check your 
posting shows up on lore before sending it again.

Thanks,
Chang

      parent reply	other threads:[~2026-10-29 20:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27  3:44 Guixiong Wei
2026-10-27  3:44 ` [PATCH v3 1/2] x86/fpu: Fix memory leak with dynamic fpstate and exec() Guixiong Wei
2026-10-27  3:45   ` Guixiong Wei
2026-10-29 20:16   ` Chang S. Bae
2026-10-27  3:44 ` [PATCH v3 2/2] selftests/x86/amx: Test dynamic fpstate cleanup across exec() Guixiong Wei
2026-10-27  3:45   ` Guixiong Wei
2026-10-27  3:45 ` [PATCH v3 0/2] x86/fpu: Fix dynamic fpstate leak on exec() Guixiong Wei
2026-10-29 20:15 ` Chang S. Bae [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9657346b-95be-4360-80ff-328bcf29d2b3@intel.com \
    --to=chang.seok.bae@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tglx@kernel.org \
    --cc=weiguixiong@bytedance.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®