From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbdBAIFA (ORCPT ); Wed, 1 Feb 2017 03:05:00 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34284 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751652AbdBAIE6 (ORCPT ); Wed, 1 Feb 2017 03:04:58 -0500 Subject: Re: [PATCH v2 4/4] perf tools: Increase index if perf_evsel__new_idx() succeeded To: Arnaldo Carvalho de Melo References: <1485862711-20216-1-git-send-email-treeze.taeung@gmail.com> <1485862711-20216-5-git-send-email-treeze.taeung@gmail.com> <20170131132541.GF4491@kernel.org> Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Wang Nan From: Taeung Song Message-ID: <9657c22b-bbd3-a41a-7b92-622004b76a98@gmail.com> Date: Wed, 1 Feb 2017 17:04:46 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170131132541.GF4491@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31/2017 10:25 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 31, 2017 at 08:38:31PM +0900, Taeung Song escreveu: >> Cc: Jiri Olsa >> Cc: Namhyung Kim >> Signed-off-by: Taeung Song > > The title of this patch is misleading, ambiguous. It leads one to have > doubt if we were not incrementing that index before and now we are, > after successfully calling perf_evsel__new_idx(). > > It should have been: > > "perf tools: Only increase index if perf_evsel__new_idx() succeeds" > Understood! I'll change the title! Thanks, Taeung