From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5671CA0EC9 for ; Mon, 11 Sep 2023 21:31:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348349AbjIKV0D (ORCPT ); Mon, 11 Sep 2023 17:26:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240561AbjIKOrT (ORCPT ); Mon, 11 Sep 2023 10:47:19 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71F53E40; Mon, 11 Sep 2023 07:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1694443633; bh=aUWLB29r0a9TYsvda4pRCCh9tA1GN6DQXSmmKb9Dj38=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fN7dshKiZHKAqsfaN0r2KVj5ZB9eHpVD12wnp3zIz1ogPNo4K8MNN6YVWxvciU0rR +iqRvnz1NlGpAsLJFlzGMB0V68HNkJ4n8+L3W0vTqXagytHxLqflAyS/ghZgD2yVZB tRIp/qORrIHOFpL7G+Mpe59QuXcKOAPoQENcGhs0= Date: Mon, 11 Sep 2023 16:47:12 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Willy Tarreau Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/nolibc: libc-test: avoid -Wstringop-overflow warnings Message-ID: <96597a87-89f2-4ec0-bf89-d1d8920f0d29@t-8ch.de> References: <20230910-nolibc-poll-fault-v1-1-2b7a16f48259@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-09-11 16:30:25+0200, Willy Tarreau wrote: > On Mon, Sep 11, 2023 at 04:26:41PM +0200, Thomas Weißschuh wrote: > > On 2023-09-11 08:04:49+0200, Willy Tarreau wrote: > > > On Sun, Sep 10, 2023 at 09:29:01PM +0200, Thomas Weißschuh wrote: > > > > Newer versions of glibc annotate the poll() function with > > > > __attribute__(access) which triggers a compiler warning inside the > > > > testcase poll_fault. > > > > Avoid this by using a plain NULL which is enough for the testcase. > > > > To avoid potential future warnings also adapt the other EFAULT > > > > testcases, except select_fault as NULL is a valid value for its > > > > argument. > > > (...) > > > > > > Looks good to me. I wouldn't be surprised if we're soon forced to do > > > the same with select() on some archs where it might be emulated. > > > > > > Feel free to push it to the shared repo. > > > > Thanks, I pushed it to the "next" branch. > > > > I'd also like to rebase the next branch onto v6.6-rc1, any objections? > > Yes, please go on! Done. I used "git rebase --signoff" and dropped the duplicate signoffs it generated on my own commits. It's also pushed to git.kernel.org, could you double-check it? Thanks, Thomas