From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5777EC46466 for ; Mon, 5 Oct 2020 14:42:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 146DB20776 for ; Mon, 5 Oct 2020 14:42:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="u7RAyaTF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726521AbgJEOmA (ORCPT ); Mon, 5 Oct 2020 10:42:00 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:44812 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726070AbgJEOl7 (ORCPT ); Mon, 5 Oct 2020 10:41:59 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 095EfJoK107006; Mon, 5 Oct 2020 09:41:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1601908879; bh=F2fRX3F6phFrNzXyEO5ny8eJjv4EnilGQEx3qSo1EYA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=u7RAyaTFMVOMPDuG4pThU3VF9HyHIiDH+8qFYw9HnWTAVHq/1vqjfTzMYyrX4Vcv7 AcyKS7LW3VZcHb0nNU8BVgA59C04FAp6pE3QUcKmMzO3lloroRKp9JreSEjQO9VueI BBpZv4qknhXwikkIR1iFTwRI8xoZHnrqt+qeheOM= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 095EfJQX092644 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Oct 2020 09:41:19 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 5 Oct 2020 09:41:19 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 5 Oct 2020 09:41:19 -0500 Received: from [10.250.71.177] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 095EfHYV099554; Mon, 5 Oct 2020 09:41:17 -0500 Subject: Re: [PATCH] leds: lm3697: Fix out-of-bound access To: CC: Marek Behun , Pavel , Linux Kernel , Linux Leds References: <20201005141334.36d9441a@blackhole.sk> <3c5fce56-8604-a7d5-1017-8a075f67061e@ti.com> From: Dan Murphy Message-ID: <966c3f39-1310-dd60-6f33-0d9464ed2ff1@ti.com> Date: Mon, 5 Oct 2020 09:41:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gabriel On 10/5/20 9:38 AM, ultracoolguy@tutanota.com wrote: > I understand. So I should leave it like it was and do the rename in another patch? You should do the fix in one patch and leave the structure name alone. The structure naming if fine and has no benefit and actually will make it more difficult for others to backport future fixes. Unless Pavel finds benefit in accepting the structure rename. Dan