From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EF8BC433F5 for ; Fri, 25 Feb 2022 19:29:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234759AbiBYT3d (ORCPT ); Fri, 25 Feb 2022 14:29:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232959AbiBYT3b (ORCPT ); Fri, 25 Feb 2022 14:29:31 -0500 Received: from mxout04.lancloud.ru (mxout04.lancloud.ru [45.84.86.114]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D26D91D8A85; Fri, 25 Feb 2022 11:28:56 -0800 (PST) Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru CCB7720A6E80 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH] sh: avoid using IRQ0 on SH3/4 From: Sergey Shtylyov To: John Paul Adrian Glaubitz , Rich Felker , , CC: Yoshinori Sato References: <2f419ed2-66b8-4098-7cd3-0fe698d341c9@omp.ru> <63f06bf0-fc7b-3c5c-8af9-5adfd7628354@omp.ru> Organization: Open Mobile Platform Message-ID: <9671b75b-d0c4-7967-a543-5eebdf942b35@omp.ru> Date: Fri, 25 Feb 2022 22:28:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/22 11:46 PM, Sergey Shtylyov wrote: [...] >>>> Using IRQ0 by the platform devices is going to be disallowed soon (see [1]) >>>> and the code supporting SH3/4 SoCs maps the IRQ #s starting at 0 -- modify >>>> that code to start the IRQ #s from 16 instead. >>>> >>>> [1] https://lore.kernel.org/all/5e001ec1-d3f1-bcb8-7f30-a6301fd9930c@omp.ru/ >>>> >>>> Signed-off-by: Sergey Shtylyov >>>> >>>> --- >>>> The patch is against Linus Torvalds' 'linux.git' repo. >>>> >>>> arch/sh/kernel/cpu/sh3/entry.S | 4 ++-- >>>> include/linux/sh_intc.h | 6 +++--- >>>> 2 files changed, 5 insertions(+), 5 deletions(-) >>>> >>>> Index: linux/arch/sh/kernel/cpu/sh3/entry.S >>>> =================================================================== >>>> --- linux.orig/arch/sh/kernel/cpu/sh3/entry.S >>>> +++ linux/arch/sh/kernel/cpu/sh3/entry.S >>>> @@ -470,9 +470,9 @@ ENTRY(handle_interrupt) >>>> mov r4, r0 ! save vector->jmp table offset for later >>>> >>>> shlr2 r4 ! vector to IRQ# conversion >>>> - add #-0x10, r4 >>>> >>>> - cmp/pz r4 ! is it a valid IRQ? >>>> + mov #0x10, r5 >>>> + cmp/ge r5, r4 ! is it a valid IRQ? >>> >>> Maybe I should've used cmp/hs... my 1st try at SH assembly! :-) > > Yeah, cmp/hs seems m ore correct as we don't subtract any more... > >> I can test your revised patch next week on my SH7785LCR. > > Please do, although testing on the AP-SH4A* bords would be a bit more > interesting, as they actually use IRQ0 for the SMSC911x chip... So, were you finally able to test it? [...] MBR, Sergey