mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	dri-devel@lists.freedesktop.org, Stefano Babic <sbabic@denx.de>,
	Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH] backlight: ili922x: fix kernel-doc warnings & notation
Date: Mon, 15 Nov 2021 18:25:08 -0800	[thread overview]
Message-ID: <9671cd29-aa9c-c93b-4bcd-43d4300a2e7c@infradead.org> (raw)
In-Reply-To: <20211115113832.rsdx3ziuujrobwxx@maple.lan>

On 11/15/21 3:38 AM, Daniel Thompson wrote:

> 
> Thanks for the fixes. Just a could of quibbles about full
> stops/periods.
> 
> 
>> ---
>>   drivers/video/backlight/ili922x.c |   29 ++++++++++++++++++----------
>>   1 file changed, 19 insertions(+), 10 deletions(-)
>>
>> --- linux-next-20211102.orig/drivers/video/backlight/ili922x.c
>> +++ linux-next-20211102/drivers/video/backlight/ili922x.c

>>   /**
>> - * CHECK_FREQ_REG(spi_device s, spi_transfer x) - Check the frequency
>> - *	for the SPI transfer. According to the datasheet, the controller
>> - *	accept higher frequency for the GRAM transfer, but it requires
>> + * CHECK_FREQ_REG() - Check the frequency for the SPI transfer
>> + *	According to the datasheet, the controller
>> + *	accepts higher frequency for the GRAM transfer, but it requires
> 
> Also missing the full stop/period in the first sentence of the summary.
> 
> Note that here the missing full stop does not benefit from a new line to
> conceal it and we will generate bad text as a result.
> 
>    Check the frequency for the SPI transfer According to the data
>    sheet, the controller accepts...

Got it. I'll send a v2.

Thanks.
-- 
~Randy

      reply	other threads:[~2021-11-16  5:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15  3:39 Randy Dunlap
2021-11-15 11:38 ` Daniel Thompson
2021-11-16  2:25   ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9671cd29-aa9c-c93b-4bcd-43d4300a2e7c@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=agust@denx.de \
    --cc=daniel.thompson@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=sbabic@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®