From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF64E1CD205 for ; Thu, 17 Apr 2025 15:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744904909; cv=none; b=ZwTJLev5bDM1ylIXRk9IxiMFLNys2lRmKLf2nh8nMgEnhgfDx8H7/hYX2xjz4GvlmPRHT5KoyGrvlk3quK3H1KLjbIjMgXvozyafLVsxrduEy62Vghsjd55qUsc5mwTkJQDPCaoRUmPtTcyca6SqIJWQrcGqpeD2opXKk03mMcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744904909; c=relaxed/simple; bh=Y/a1RyMGC0x7pKJnb5bi8pFDmsxQboG7fC53/IeNtnw=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=G+p+HypXX8oeuPT7W7bXrvGi+UTjuGFy3AdkbtPuc+bXzVXBMKA02zOm5h/jGKTMY1hk5Iljj250eGHFhpYIYIOd6qgYdQjcxvQT3uAhL94GWdnNdSH4lwrV+BlqnaG6uBEalBbke4QtIV1LambWBShzvAswsf5C42MVVoOX40Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JtxyYKu9; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JtxyYKu9" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3995ff6b066so599394f8f.3 for ; Thu, 17 Apr 2025 08:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744904906; x=1745509706; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=LbDTz1govFuJqW1HLjiNGtY4aJqmXA2tH78xltv4vpA=; b=JtxyYKu9bc4zg2Bkf/ywd1JPeEo/3RuPiwin0Q/f1xoziXcD6pywHG40BrX5Dxyu97 aNtvW8dJ/CPE9pg4z2v0TFz+t+tlS9N3/p/bS1VnOubkJg0LCYR3MCqtg+tMhhY6oqWA 83ljAjnYBZ4mCp5X4ReijwY9G9bjsnVRlzD7tRE8++tKKPHX+UwKGp8aLfX9GdwlbmZ9 8k4Vy5VXUguvefJJHOIPj6iJQuEL5AXsl0pPNe+JIGaKWa/OS4SIuzPoKdmhJgJUY+pB PzbEfAdzvAf6FTRWLUHZM4Tlq6jeHBdvonohpG/RO07biKYo1fm84YJ8b2jMUABbREis lWCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744904906; x=1745509706; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LbDTz1govFuJqW1HLjiNGtY4aJqmXA2tH78xltv4vpA=; b=Gk3sKEMz2Qtiutb/aJU/9NSFiZmNq4lfcntGMF5+rPURtm3D+U7KGAF/ud3pKEkGAi yrnIcTslQrjwugLB5B4TwmAYD7A81jNHf3ueB1yS00ypoEEuDmSHupCAAtLXIhnBVwwI Yy8dUY1XJNrxj/+F3iSLo8M+Z9eRhD5gM4mTl/aYJfkd0ncl+PlytrJ1+3+Z/s6NBQRL dUIYWeTnZAs7MZroi4FDCGZ03VI5n1i4Vwa9vxguJFD6fYwF184QqBJEUuABG879arHM T5exC/52pePOhrXZNsM7HALydS/cqgmxMbUOAehZfwLKnu7TnfRT2DwRMfLmiCzDr2bV pAxQ== X-Forwarded-Encrypted: i=1; AJvYcCVky93sbjFELukrR8nUhdOElygbOW3MAVhPwg554MM3RvRNfJDrMzihBqtOlw9ZSGpNBZr4x3qk1j3qkn8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5TqHPStFdfEVJVxbaMrqo5ovhPR64jsbq5r7Vrf/Kbx0M3ZRm E86G91vGrGdRbf6buhxh1V6423LKeCGgpcCBjjhhVYUdOZX8AWilrRFaJDFhytQ= X-Gm-Gg: ASbGncsD/fn8RfAPShiScWNSKlCpYM36oC2hwKrg1wP0Z4BtG+nf83rme0k+5fGmYNQ zfNxSVKSOK6HWQb4K3DO38k1/2HKJ4v4+lyJ57aEjF8VMbfvqkzbviz0iRwtWzOzCS2lEVL+1H7 HVrMj5OzbkvYUNcxAkDyXEEY4jWQc7mfpQPtGj89fTY/Xtmp2gMukyToNY4mpDbGsixP6ZSKURs xe9fTAlT55FtJdQYYo2QkYiQezBiIwNJelfcvg2Fx2QJST6RuM/hTKghY08ucfQ7YzvmYu0PjSr +2e1is74poG2TJfA+SpIPyWEY1cVIHZqCq3e5Kv5sYSbTYEy3sVKbR2GNm3+Aj/ZRYRn3LdMD9i B8z6g00L1IgFAUEY= X-Google-Smtp-Source: AGHT+IESUQJ7NOxOmnwu3OdSTKOT8rUo3iZKc5XBtYlZsnAtS4EidAQdEv9hWGPKjw9Go7Hovic/9g== X-Received: by 2002:a05:6000:2408:b0:38f:4f60:e669 with SMTP id ffacd0b85a97d-39ee5b33b16mr4947410f8f.29.1744904906292; Thu, 17 Apr 2025 08:48:26 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:a7f9:634b:42d:1546? ([2a01:e0a:3d9:2080:a7f9:634b:42d:1546]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eae977513sm20404419f8f.42.2025.04.17.08.48.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Apr 2025 08:48:25 -0700 (PDT) Message-ID: <96737f4e-4a7b-41dc-97d7-9d4be13d5ff6@linaro.org> Date: Thu, 17 Apr 2025 17:48:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 5/7] drm/bridge: analogix_dp: inline analogix_dp_prepare_panel() To: Dmitry Baryshkov , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> <20250401-panel-return-void-v1-5-93e1be33dc8d@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250401-panel-return-void-v1-5-93e1be33dc8d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/04/2025 07:11, Dmitry Baryshkov wrote: > The analogix_dp_prepare_panel() is now only calling a corresponding > drm_panel function. Inline it to simplify the code. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 43 +++++----------------- > 1 file changed, 10 insertions(+), 33 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index 1ec4d277fe6bb03ad9eb8451ae2af5ad5ada0978..f60068011008482f7b7b2edfcab5fb1b3e9e130f 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -955,33 +955,6 @@ static int analogix_dp_disable_psr(struct analogix_dp_device *dp) > return analogix_dp_send_psr_spd(dp, &psr_vsc, true); > } > > -/* > - * This function is a bit of a catch-all for panel preparation, hopefully > - * simplifying the logic of functions that need to prepare/unprepare the panel > - * below. > - * > - * If @prepare is true, this function will prepare the panel. Conversely, if it > - * is false, the panel will be unprepared. > - * > - * The function will disregard the current state > - * of the panel and either prepare/unprepare the panel based on @prepare. > - */ > -static int analogix_dp_prepare_panel(struct analogix_dp_device *dp, > - bool prepare) > -{ > - int ret = 0; > - > - if (!dp->plat_data->panel) > - return 0; > - > - if (prepare) > - ret = drm_panel_prepare(dp->plat_data->panel); > - else > - ret = drm_panel_unprepare(dp->plat_data->panel); > - > - return ret; > -} > - > static int analogix_dp_get_modes(struct drm_connector *connector) > { > struct analogix_dp_device *dp = to_dp(connector); > @@ -1174,9 +1147,11 @@ static void analogix_dp_bridge_atomic_pre_enable(struct drm_bridge *bridge, > if (old_crtc_state && old_crtc_state->self_refresh_active) > return; > > - ret = analogix_dp_prepare_panel(dp, true); > - if (ret) > - DRM_ERROR("failed to setup the panel ret = %d\n", ret); > + if (dp->plat_data->panel) { > + ret = drm_panel_prepare(dp->plat_data->panel); > + if (ret) > + DRM_ERROR("failed to prepare the panel ret = %d\n", ret); > + } > } > > static int analogix_dp_set_bridge(struct analogix_dp_device *dp) > @@ -1274,9 +1249,11 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge) > > pm_runtime_put_sync(dp->dev); > > - ret = analogix_dp_prepare_panel(dp, false); > - if (ret) > - DRM_ERROR("failed to setup the panel ret = %d\n", ret); > + if (dp->plat_data->panel) { > + ret = drm_panel_unprepare(dp->plat_data->panel); > + if (ret) > + DRM_ERROR("failed to unprepare the panel ret = %d\n", ret); > + } > > dp->fast_train_enable = false; > dp->psr_supported = false; > Reviewed-by: Neil Armstrong