From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCA5A314A9E; Wed, 4 Feb 2026 22:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770243684; cv=none; b=qAIri73v8O7az9noMizG9fwcz6NI45cWrccTkOx494oqUerIpSRyUig318dtpKIC0xtkS7E9e2xvAtc5pqGTlyBDSMatGqdd3YmLu5Q4C1nIDcHRiUsaWNXl2BiqyBdFscLvfpeKnI0xWgB2QUQQ6Xo4+JoqvpL8jWNTC+++L/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770243684; c=relaxed/simple; bh=AxHfxhuAQo8l9CiWoCCZvEY2xn5mgWBR1SX9HFhxEVM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Uod9DIHszA3gc2kkmJntmGjLGmIDNfEYf8pcYT/EZ8CuD+Bt1OxSqfzj2Ccmxgbe7zQ8opmtwFdOaRoiFGIhAhAVTgVWg2QmnptJPhYf40mBAuuV7n5GiXUfg5KT5inOLMSa6sgX8KNGD7yb6figaEv8HSoyWwKpxcJExWl3dAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com; spf=pass smtp.mailfrom=perches.com; arc=none smtp.client-ip=216.40.44.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=perches.com Received: from omf12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B67D157517; Wed, 4 Feb 2026 22:21:16 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA id CCEB617; Wed, 4 Feb 2026 22:21:13 +0000 (UTC) Message-ID: <9675d6ac5ba6ff51d47177d3802156e2007b494e.camel@perches.com> Subject: Re: [PATCH] checkpatch: add check for missing */ in spdx line From: Joe Perches To: Tim Bird , apw@canonical.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com Cc: linux-spdx@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 04 Feb 2026 14:21:10 -0800 In-Reply-To: <20260204213823.1754560-1-tim.bird@sony.com> References: <20260204213823.1754560-1-tim.bird@sony.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Stat-Signature: ny4iabrjtmk3o1f3yj4tmnh9mcqd3m5c X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: CCEB617 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/PuP96ePSCNGSm45YKk2oZog3cNFe7bkk= X-HE-Tag: 1770243673-888622 X-HE-Meta: U2FsdGVkX1/J2fB9k7xwmDnWBL60zuFTvLPgXm9PoFVr6ixP0Q+J4/55N+Pg29IcERq47RwSxNmzDO6iKqk6oGaFO+AbQGgsW/gULwJx6xxviYqtu2dxZMQ1jyxRsc8vBCsKwQ4aQpR3WkfimS+FYxfOTPkxvG+mkUppLgnAcdNi3k/szA3JriSdBqb8PRAiIGYPuF9/kvQjwaxlxlP81Vf2zEeREd201WwR1Hgjf+3HpYlTzPfM759oFuAtJCJkX8z2Nb8kqnsYrQyvzvf789ImmPolXT5at/qW+gF1XH1fqzeyJx5ITba7m2JAEj8Zs6pffgDE1RnaRb9FGGmg5mqSiETMUuUr On Wed, 2026-02-04 at 14:38 -0700, Tim Bird wrote: > Add an explicit check for leading /* but missing */ > to avoid a malformed SPDX line. >=20 > In many cases an SPDX-License-Identifier line immediately > precedes another C-style comment. In that case, if > the SPDX line starts with '/*' but is missing the closing '*/', > the compiler may not catch it (the leading '/*' on > the next line and the rest of the header comment is just > treated as part of the SPDX comment). Nack. There too many existing uses. $ git grep '^/\*.*SPDX' | grep -v '\*/'| wc -l 855 >=20 > Signed-off-by: Tim Bird > --- > scripts/checkpatch.pl | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index c0250244cf7a..1cc3fd5e72af 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -3794,6 +3794,11 @@ sub process { > WARN("SPDX_LICENSE_TAG", > "Improper SPDX comment style for '$realfile', please use '$com= ment' instead\n" . $herecurr); > } > + if ($comment eq '/*' && > + $rawline !~ m@\*/@) { > + WARN("SPDX_LICENSE_TAG", > + "Improper SPDX comment style for '$realfile', missing closing = '*/'\n" . $herecurr); > + } > =20 > if ($comment !~ /^$/ && > $rawline !~ m@^\+\Q$comment\E SPDX-License-Identifier: @) {