From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Jens Glathe <jens.glathe@oldschoolsolutions.biz>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: Add Lenovo IdeaPad Slim 5x 14Q8X9
Date: Tue, 8 Sep 2026 08:59:25 +0200 [thread overview]
Message-ID: <9678155f-d1d2-4592-aa95-28ebcb412c9d@oss.qualcomm.com> (raw)
In-Reply-To: <84e545b9-3c81-49d0-9ac4-1aa84eabd3d0@oldschoolsolutions.biz>
On 9/8/26 7:18 AM, Jens Glathe wrote:
> Hi Konrad,
>
> On 07.09.26 11:14, Konrad Dybcio wrote:
>> On 9/6/26 2:22 PM, Jens Glathe via B4 Relay wrote:
>>> From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
>>>
>>> Add a common DTSI plus LCD and OLED board files for the Lenovo
>>> IdeaPad Slim 5 14Q8X9 (machine type 83HL) on X1P42100. In some
>>> regions this SKU is sold as "IdeaPad Slim 5x"; the "x" is the
>>> Qualcomm suffix in Lenovo's current IdeaPad naming (i = Intel,
>>> a = AMD, x = Qualcomm).
[...]
>>> + vreg_l4b_1p8: ldo4 {
>>> + regulator-name = "vreg_l4b_1p8";
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <1800000>;
>>> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>>> +
>>> + regulator-state-mem {
>>> + regulator-on-in-suspend;
>>> + };
>> Why is this necessary?
>
> I had a debug session on the Thinkbook 16 with Grok where I chased stuck mouse via USB dongle after long suspend. This is what resulted from this, PTN3222 losing its state on deep suspend when the vreg shuts off. And it solved the problem, propagated it over to the Ideapad 5 device trees. I also observed that on the Ideapad 5 2in1 before. Never seen on the Slim5x, but I got that one after the change was in. So, yes, IMO.
Alright, let's at least leave a comment for the future reader
Konrad
prev parent reply other threads:[~2026-09-08 6:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 12:22 [PATCH 0/3] " Jens Glathe via B4 Relay
2026-09-06 12:22 ` [PATCH 1/3] dt-bindings: arm: qcom: Add Lenovo Ideapad Slim 5 variants Jens Glathe via B4 Relay
2026-09-09 7:53 ` Krzysztof Kozlowski
2026-09-06 12:22 ` [PATCH 2/3] firmware: qcom: scm: Allow QSEECOM on Lenovo IdeaPad 5 models Jens Glathe via B4 Relay
2026-09-06 12:22 ` [PATCH 3/3] arm64: dts: qcom: Add Lenovo IdeaPad Slim 5x 14Q8X9 Jens Glathe via B4 Relay
2026-09-07 9:14 ` Konrad Dybcio
2026-09-08 5:18 ` Jens Glathe
2026-09-08 6:59 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9678155f-d1d2-4592-aa95-28ebcb412c9d@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jens.glathe@oldschoolsolutions.biz \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®