mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Cress, Andrew R" <andrew.r.cress@intel.com>
To: "'Douglas Gilbert'" <dougg@torque.net>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH-2.4.3] scsi logging
Date: Tue, 10 Jul 2001 05:40:23 -0700	[thread overview]
Message-ID: <9678C2B4D848D41187450090276D1FAE0635F135@FMSMSX32> (raw)


DG> I would object to point 3). SANE, and to a lesser extent
DG> cdrecord, execute lots of commands that give SCSI check
DG> conditions and would bloat the log and the console with
DG> many serious looking messages. [...]

Doug,

Would it be possible to recognize & filter the specific errors output by
SANE and cdrecord rather than removing all sg sense errors?  Or to ignore
all but certain sense codes unless SG_SET_DEBUG is set?
What I'm most concerned about is to make sure that any media problems on
fixed disks (03/11/00, etc.) don't get missed.  

Perhaps something like: 
if (CHECK_CONDITION ...) {
  if ((type == disk && (key == MEDIUM_ERROR || key == HARDWARE_ERROR))
     || (sdp->sgdebug > 0))
        print_req_sense(...)
  }
How about that?

Andy



             reply	other threads:[~2001-07-10 12:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-10 12:40 Cress, Andrew R [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-07-10  4:34 Douglas Gilbert
2001-07-10 13:35 ` Eddie Williams
2001-07-10 16:17   ` Mike Anderson
2001-07-09 18:24 Cress, Andrew R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9678C2B4D848D41187450090276D1FAE0635F135@FMSMSX32 \
    --to=andrew.r.cress@intel.com \
    --cc=dougg@torque.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®