From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751565AbeERLxM (ORCPT ); Fri, 18 May 2018 07:53:12 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:29603 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184AbeERLxH (ORCPT ); Fri, 18 May 2018 07:53:07 -0400 Subject: Re: [PATCH 1/3] ARM: dra762: hwmod: Add MCAN support To: Tony Lindgren CC: , , , , , , , , References: <1523181542-3770-1-git-send-email-faiz_abbas@ti.com> <1523181542-3770-2-git-send-email-faiz_abbas@ti.com> <20180517210931.GQ98604@atomide.com> From: Faiz Abbas Message-ID: <96794128-c107-9b04-aed5-5dd9caa7a605@ti.com> Date: Fri, 18 May 2018 17:24:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180517210931.GQ98604@atomide.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tony, On Friday 18 May 2018 02:39 AM, Tony Lindgren wrote: > * Faiz Abbas [180408 09:59]: >> From: Lokesh Vutla >> >> Add MCAN hwmod data and register it for dra762 silicons. >> >> Signed-off-by: Lokesh Vutla >> Signed-off-by: Faiz Abbas >> --- >> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 32 +++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >> index 62352d1..a2cd7f8 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c >> @@ -1356,6 +1356,29 @@ static struct omap_hwmod dra7xx_mailbox13_hwmod = { >> }; >> >> /* >> + * 'mcan' class >> + * >> + */ >> +static struct omap_hwmod_class dra76x_mcan_hwmod_class = { >> + .name = "mcan", >> +}; >> + >> +/* mcan */ >> +static struct omap_hwmod dra76x_mcan_hwmod = { >> + .name = "mcan", >> + .class = &dra76x_mcan_hwmod_class, >> + .clkdm_name = "wkupaon_clkdm", >> + .main_clk = "mcan_clk", >> + .prcm = { >> + .omap4 = { >> + .clkctrl_offs = DRA7XX_CM_WKUPAON_ADC_CLKCTRL_OFFSET, >> + .context_offs = DRA7XX_RM_WKUPAON_ADC_CONTEXT_OFFSET, >> + .modulemode = MODULEMODE_SWCTRL, >> + }, >> + }, >> +}; > > So based on the ti-sysc related dts comments, this patch should > work except you should be able to just leave out the clocks here > with the dts changes. > >> +/* >> * 'mcspi' class >> * >> */ >> @@ -3818,6 +3841,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per2__epwmss2 = { >> .user = OCP_USER_MPU, >> }; >> >> +/* l3_main_1 -> mcan */ >> +static struct omap_hwmod_ocp_if dra76x_l3_main_1__mcan = { >> + .master = &dra7xx_l3_main_1_hwmod, >> + .slave = &dra76x_mcan_hwmod, >> + .clk = "l3_iclk_div", >> + .user = OCP_USER_MPU | OCP_USER_SDMA, >> +}; >> + >> static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = { >> &dra7xx_l3_main_1__dmm, >> &dra7xx_l3_main_2__l3_instr, >> @@ -3958,6 +3989,7 @@ static struct omap_hwmod_ocp_if *dra7xx_gp_hwmod_ocp_ifs[] __initdata = { >> /* SoC variant specific hwmod links */ >> static struct omap_hwmod_ocp_if *dra76x_hwmod_ocp_ifs[] __initdata = { >> &dra7xx_l4_per3__usb_otg_ss4, >> + &dra76x_l3_main_1__mcan, >> NULL, >> }; > > So the omap_hwmod_class, omap_hwmod_ocp_if and entry on the > dra76x_hwmod_ocp_ifs list are still needed with ti-sysc for a > while. Eventually that data will just come from the dts interconnect > hierarchy. For struct omap_hwmod_class_sysconfig, ti-sysc will > allocate and it based on the dts data. > Thanks for the detailed pointers. I will figure out the ti-sysc node that needs to be added and post a v2. Thanks, Faiz