From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1CAB1CAA63 for ; Sat, 25 Jan 2025 13:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737810299; cv=none; b=ohrTZsTe1GwRC9hp6TcxvSbBbHwYTL03kUcWJCr/yGsG2ggfIfTIlc/b1yLXlURqnmf4HVa+ezlLSVXkQn1jDs3Wx0TznS5OfyohuSMQ1ZiOATayeNqvye2PzfWnZM1d6/ptmSKX1JSMS7BrEtQ7AVrBNhVDoGMcCwyN/y5KxSw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737810299; c=relaxed/simple; bh=fF0AHv0s3S+dBIkriG8rfycx3SWlry9DEa+eTSo1+Js=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iCwq9GFIchRyan6hc9jB4HfHUmEzxbuvXqXQCW47tJFFKsd5/JFcdfWalfBuzPXrVWKz3p29P/ilwrjwujIw2JIZ/N3iTL2nMvW3Riy8erUVIu9Br+TyLxkNEF7wutEaUGA9psobNKXN9J8GdhbK87/cFsex92Eq05BcFxGxosw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YSNeCLH9; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YSNeCLH9" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-438a39e659cso19031295e9.2 for ; Sat, 25 Jan 2025 05:04:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737810296; x=1738415096; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ufdypkJNjHswejxJubFk9kEYQm8Yr9F5qH7/Hz14nEU=; b=YSNeCLH94OQrQQEBh9OAQx6JHTw5s+Zb3FJ14YicrfjPIvSc90IfCDXZwp8Lb+sD6N L1OlKwdS6S+U2pEwNT3YDf9kFYkgqUCqQ+uHT1BwSAJFtUV+WIb08mEzjPq2X6mIx+UR uencJywzXu7pCrGvqU7Ln30xzlppJjs8DUbDG2E5qJDy01aZ8B2gAE0Z92HXMP4zNlFU JgY4wPtDIK06fLiqN2QMYCx3Tr2XYSmUylH3H2B8rO4OUgyPgLjxc3mor6cWsMRVbWP6 Q73YJC9A8Ra+voAn6KXWcs6b8ktLjQvtZfeoIbB4Kd14vG0MyuoeUw7C+6AOzVFqd52T kuoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737810296; x=1738415096; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ufdypkJNjHswejxJubFk9kEYQm8Yr9F5qH7/Hz14nEU=; b=RmddNdO8iEETGO4xBu22T7AtlDb53IaC72y5ZgBVeLj5ly7HUaEKO7VlTDYfaTw4+d xECyXQkKP9bSdoI0mHgaLFKBTL7ELDAVWC4++MTKxhYfVmyHAH1cwBVwVNAgQCa/STZU TkmLvlUxgXxgG94Bg77nNbsH0J/mQy3hrefKBvgBQ609H2ekk9craNkdlKMr/3O7mixe IhBEVcOzwgMXAe6Z3xdMu8YWRfGj3rDIR9Qadmxf35LQ4eaebcb5ZnZn/qy02PObgrij bbK+yEomM8US788prm0M3P1np1DeFgE4KQluJRtFdP3GEL/yy0GdOL8mCMgvEs2qSt+9 y19g== X-Forwarded-Encrypted: i=1; AJvYcCUU2z9lMFXFgF07yQmQX8xX3HaWqZznCHgmkEHPlsowZOq6urRshdsefut4R5b/7q4813DucBmaRkHBB8M=@vger.kernel.org X-Gm-Message-State: AOJu0YzUcMfs0vGRRsMhPCeYaZMuCc64Q3ApAXifWjMhQOpelz63AseG MJ2I8/tSp79pfWSOYPUcJJM9HS75iPovPhzK0472Rr2LQREZrqx7Xs9IWSeDu04= X-Gm-Gg: ASbGncuUsfjGAs1tyH0jY981dPxzVMe71pwv/ANo7sTWorIqGszXmQGAkPiuHMOfpsN 5FX7HJwqNFwJLzdjpD0XpAb8OdGbCV4U3Da9UB101CfyQ2Vt094HRSjJQVCvF0B8rPgOHmtkNmN DQ0nPsKN6as42ErLkdxQZHXRYuS9joCwpwvnZwnVpr+oJGOwC8tRGpCMgBeqdVHGsOHRZtz2brE YJ1v4L1HXjaumdKho9GDLqlHEV7Ec5NUC4IB15y6RJBKvIvY8G3ydvaHS+tL1/moqWp6UZWgk1l al7PK3V9xg== X-Google-Smtp-Source: AGHT+IEaOVgzG6Qtw0HZT4iWc73ce/VOtEgJOp3dSxRw2PlxaNl3qvT2R0XWbkFb0aXpK24XwpEiwA== X-Received: by 2002:a05:600c:5486:b0:434:a10f:c3 with SMTP id 5b1f17b1804b1-438913cae48mr287922225e9.9.1737810296292; Sat, 25 Jan 2025 05:04:56 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438bd4d3dbcsm61443145e9.40.2025.01.25.05.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jan 2025 05:04:55 -0800 (PST) Date: Sat, 25 Jan 2025 16:04:52 +0300 From: Dan Carpenter To: zuoqian Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2] cpufreq: scpi: compare kHz instead of Hz Message-ID: <967a5b3e-197a-4b90-9fe3-9b10782d677c@stanley.mountain> References: <20250123075321.4442-1-zuoqian113@gmail.com> <20250125084950.1680-1-zuoqian113@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250125084950.1680-1-zuoqian113@gmail.com> On Sat, Jan 25, 2025 at 08:49:49AM +0000, zuoqian wrote: > The CPU rate from clk_get_rate() may not be divisible by 1000 > (e.g., 133333333). But the rate calculated from frequency(kHz) is > always divisible by 1000 (e.g., 133333000). > Comparing the rate causes a warning during CPU scaling: > "cpufreq: __target_index: Failed to change cpu frequency: -5". > When we choose to compare kHz here, the issue does not occur. > > Fixes: 343a8d17fa8d ("cpufreq: scpi: remove arm_big_little dependency") > Signed-off-by: zuoqian > --- > V1 -> V2: rename freq to freq_khz, change rate to unsigned long, and > update patch summary. Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter