From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C37C61D85 for ; Tue, 21 Nov 2023 00:55:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232788AbjKUAzI (ORCPT ); Mon, 20 Nov 2023 19:55:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232749AbjKUAzG (ORCPT ); Mon, 20 Nov 2023 19:55:06 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2E00A2; Mon, 20 Nov 2023 16:55:02 -0800 (PST) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AL0mRni010042; Tue, 21 Nov 2023 00:54:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=DXfbZLYtbV4uRYrSHUG75mp52Y0nIZGcdKa0+0YYHLM=; b=NOjJVF9LOPwRbXv6vMfiT3GZzAwWC4VyY8SSMR3P/fdvfoklkfP4ZrcVTIMxjmz8dpKd EH3ce/En2SNH/NZurTTJNTlCxSAMZrQpDsSiVVVg1JLUfDgYFqJnLSyv5O6j05RR9KbP CThhvAXNcts8FOOlcBo1talVLke8nWcYo1cYRyFtKcLSx0O2x5lFtNBaratX2fAjvpFM ThSF4s21018ZXgfs7K09KsUXm63KY2zwsdTDFIkY48j8DPV21SssJt+brqniyGjJJ5vw 5nPpw4K7haBPiMq40u1oUaGD1r7TaZO0G5EJaCYpxrpd5UjGrOmxEayoSrXA29WDIndj KQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ug26ttdmh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 00:54:57 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AL0su08006799 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 00:54:56 GMT Received: from [10.239.132.204] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 20 Nov 2023 16:54:51 -0800 Message-ID: <967ebf17-80f9-4b20-958c-92e89cc13782@quicinc.com> Date: Tue, 21 Nov 2023 08:54:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/16] arm64: dts: qcom: sm8550-aim300: add flash LEDs To: Krzysztof Kozlowski , , , , , , , CC: , , , References: <20231117101817.4401-1-quic_tengfan@quicinc.com> <20231117101817.4401-10-quic_tengfan@quicinc.com> <5fcd89c4-8603-4569-a77d-cfcfa1ad0b4f@linaro.org> From: Tengfei Fan In-Reply-To: <5fcd89c4-8603-4569-a77d-cfcfa1ad0b4f@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: zzSpokh4bcxyjWdPa0RYnRa0HxegSC-m X-Proofpoint-GUID: zzSpokh4bcxyjWdPa0RYnRa0HxegSC-m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-20_22,2023-11-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=408 priorityscore=1501 impostorscore=0 suspectscore=0 clxscore=1015 bulkscore=0 spamscore=0 phishscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311210002 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 11/17/2023 6:34 PM, Krzysztof Kozlowski 写道: > On 17/11/2023 11:18, Tengfei Fan wrote: >> Enable PM8550 PMIC flash LED controller and add two flash LEDs using >> four current outputs. >> >> Signed-off-by: Tengfei Fan >> --- > > NAK, it's initial submission. > > Stop useless splitting of work which is done. You cannot have "release > late, release often". The rule is: "release early, release often". > > Or you want to split DTS per each line? > > Best regards, > Krzysztof > Hi Krzysztof, In next version patch series, I will do a board patch which contain all the functions which were splited in current patch series. -- Thx and BRs, Tengfei Fan