From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5475250BF3 for ; Wed, 19 Mar 2025 12:42:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742388173; cv=none; b=AwQ0F+r6MkSM/j/LE/pA2nQL96yWfOsdjla34Q4ZY8GJkeh6nbXlK9ukQ1Je0Ye5jJ2qghjakZsj0hoBm6bm4gKNtvemgjqpvb9ztY8MapsFRJxy3j1QqChuEuN88i19xe6wxzT/hTRzft8MMt5/9r4Uos39Ra5QijqLThBeJN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742388173; c=relaxed/simple; bh=fZ4N8rOOZtziflSX/PfQXG9Biqs1R/I42srqwO5HUfc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tnstaghGbB1cayFRMnNEBA4BpKA6LleqWTayQHT4gBBbDWEQQSTEQgFMV1impzlJGXJRFU0On6CEZnRviXhaRlK1spPPdorLbcmsh/vCsLVyDQQw5JRzJnJQ8QjThxKVFyrRVHMA7dM1DUDXfe9osWeAn56uhxzIzzLJNfO0i+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=xgTuQ17q; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="xgTuQ17q" Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-85dac9728cdso184545939f.0 for ; Wed, 19 Mar 2025 05:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1742388171; x=1742992971; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kyeWtEw8zSEmdt2B2rWBlorZy53Vw89+CNeJItSMOLA=; b=xgTuQ17q1KtG+lF1gOtB3V6eu2L3aisyk5JioY2J9ZOSXjsfK+zA9M1q9/aRht1CSH SNPE7WhB5aZdLzfuRJYw/od6WXmSA41L7xSwWOWVbcBURI4ains2mzZ8UaJssGGKkGLo 5HN9rFGi7kVqSg2sdaJ99RmMCOn2aLrrNlgufq+0GnJfRURvfr2WgFsPYxTnn9FQyiqn TKgON9AB1/rxtKznsaKOJbNbTypHRrQfMaFSCMZU1lFRBt0aXbax2TxaAmhIREuXj5jE lZD92Xl0aNZJISmtortRs5nhypmHlWyulTmlltOgy2QHAWeL8MC0LTrs8IWL5nW6+z19 4qBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742388171; x=1742992971; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kyeWtEw8zSEmdt2B2rWBlorZy53Vw89+CNeJItSMOLA=; b=Bgby+c9AkGk+6rGgjrrZmB4ADGf3iTwj860Un6YvtGs2KaLmZoh11m0J7F2gyVdTJK 3+uLtYQ5zV0iYSz0PV/G8fH/jFj739X7DRRK56/Y7CJoCNFYVPgvaWq+2Auir0fDqxvN w22jn4xASQs4xAax3ZZZ2dkfk57ns+aX6gHJL2yOw3J6oWMlIKSpuCo86GlY8C95SYeF Wzb5BHaBvkwZXNP+Ba9+QVpNRQBeER/JbiP0AKrV679eY7lDeXfUqG4BHFpbkHNSgrpm dFT2Bs0CXEvKiCGJAfHF5iR9V3h50zTd4/4JtABmlTawe11wzyV+kIDYYuTLu79Wp0jD PTdQ== X-Forwarded-Encrypted: i=1; AJvYcCWfAP4bB0W/sNRl8g3yLunFl6fSl/6+gs6exIRUBEjUYA3Vf8NcJYbiPO0Ef+e3tr+kf+Aht0OahiiU8Aw=@vger.kernel.org X-Gm-Message-State: AOJu0YyagIZ71HFQ4tRn06HFCTKWbLzbaZHXCMpcuYoi8FZYs28URR1+ 8+YqA5wMrtUinqA5eE3dImBY2V46AXHuKboyeGVPPe2V1aMOh4bE8utHQHZ8zlJA2xjvj5TUwd+ WL8c= X-Gm-Gg: ASbGncu45KlFXxQUmFeZnOZrLiWiulwVPJ8xfTD5ad3NWSUu0Q+Lfd32kCpzwcSXmPm TbNFCfCfDwyxK95hIxIFKwqWPoxzCBGi4FxwzsHeYrQem4lok3VS3zFLXqQFhW/OzSqcf92G5sy Yt01SjjqYTh7I8PlS3vU3ZnSZF45hEn1A0jenBdg6CIihqCkslPIBQF2rrGxPEA1pgmd4vvi/Lw 0J6QXcJrK6pl6sqmiThZ7gIPCnGsAZY1GnGBhmHkVqTivhi3lqb8ALhb+WyHXr2Mp+HmBIhdeOJ QRNg4ttgmW61VM6Q3xY16A9VlRIvjJI1LtRljk7kIlO6ecSJkHTxVylhqZtbkoU62nJxiPg+XpV rt07fPJJVNb1WYVtsDQ== X-Google-Smtp-Source: AGHT+IH7sjljQM+QmrKBokA3matC2RiNwzx/l2tsu1F5XWLbsNSdMzt3SBx/tCoCiYaMZ1SyjlQ1fg== X-Received: by 2002:a05:6602:388a:b0:855:5e3a:e56b with SMTP id ca18e2360f4ac-85e13870076mr284771939f.12.1742388170792; Wed, 19 Mar 2025 05:42:50 -0700 (PDT) Received: from [10.211.55.5] (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f2637fb184sm3185854173.92.2025.03.19.05.42.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Mar 2025 05:42:50 -0700 (PDT) Message-ID: <967f135b-9592-4f85-86f9-5c3e31123c3f@riscstar.com> Date: Wed, 19 Mar 2025 07:42:49 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/2] i2c: spacemit: add support for SpacemiT K1 SoC To: Troy Mitchell , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan Cc: linux-riscv@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, spacemit@lists.linux.dev References: <20250319-k1-i2c-master-v8-0-013e2df2b78d@gmail.com> <20250319-k1-i2c-master-v8-2-013e2df2b78d@gmail.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20250319-k1-i2c-master-v8-2-013e2df2b78d@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/19/25 4:29 AM, Troy Mitchell wrote: > This patch introduces basic I2C support for the SpacemiT K1 SoC, > utilizing interrupts for transfers. > > The driver has been tested using i2c-tools on a Bananapi-F3 board, > and basic I2C read/write operations have been confirmed to work. So you removed support for the clock-frequency property, which addresses both of the things I commented on in the last version. This is great; I hope Andi is satisfied what anything else you did and will merge this. Nice work Troy. -Alex > > Reviewed-by: Alex Elder > Link: https://lore.kernel.org/all/20250128-k1-maintainer-1-v1-1-e5dec4f379eb@gentoo.org [1] > Signed-off-by: Troy Mitchell > --- . . .