From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932156AbcEBVZn (ORCPT ); Mon, 2 May 2016 17:25:43 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:38603 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755061AbcEBVZm (ORCPT ); Mon, 2 May 2016 17:25:42 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Mon, 02 May 2016 14:22:04 -0700 From: Stefan Agner To: Arnd Bergmann , David Airlie Cc: Alison Wang , David Airlie , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Xiubo Li , Daniel Vetter , Jianwei Wang , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/fsl-dcu: add COMMON_CLK dependency In-Reply-To: <1462186839-2224021-1-git-send-email-arnd@arndb.de> References: <1462186839-2224021-1-git-send-email-arnd@arndb.de> Message-ID: <96882621acf64dca8d6c1d2f25307385@agner.ch> User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-05-02 04:00, Arnd Bergmann wrote: > The fsl dcu now uses the clk-provider interfaces, which are not available > when CONFIG_COMMON_CLK is disabled: > > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c: In function 'fsl_dcu_drm_probe': > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:362:20: error: implicit > declaration of function '__clk_get_name' > [-Werror=implicit-function-declaration] > pix_clk_in_name = __clk_get_name(pix_clk_in); > > This adds a Kconfig dependency to prevent the driver from being enabled > in this case. > > Signed-off-by: Arnd Bergmann > Fixes: 2d701449bce1 ("drm/fsl-dcu: use common clock framework for > pixel clock divider") Oh right, thx! Acked-by: Stefan Agner @Dave, can you pick that up directly or do you prefer a pull request? -- Stefan > --- > drivers/gpu/drm/fsl-dcu/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig > index c78cf3f605d0..b9c714de6e40 100644 > --- a/drivers/gpu/drm/fsl-dcu/Kconfig > +++ b/drivers/gpu/drm/fsl-dcu/Kconfig > @@ -1,6 +1,6 @@ > config DRM_FSL_DCU > tristate "DRM Support for Freescale DCU" > - depends on DRM && OF && ARM > + depends on DRM && OF && ARM && COMMON_CLK > select BACKLIGHT_CLASS_DEVICE > select BACKLIGHT_LCD_SUPPORT > select DRM_KMS_HELPER