From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB4573CC9F5 for ; Tue, 17 Mar 2026 14:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773759577; cv=none; b=gvjnUDo4OO+c7PZwNAsuGEf0/EXuADtXPKpBIztYhLZp/0uzdKQAgzQBf00xD8zz+0fL/jYVyyAH4NPREBG1sn4bJefhCAWu4dfctlhdTG0l7FM9JC8P6tzsudF4cQGkQpOEWaYQdei6U+bJ4YasCBeaVAogO0vGGbpkCV2ml30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773759577; c=relaxed/simple; bh=rUTojCZuqPlbT8TmP1stlKMR0/7wIMn4bg1YzKidpcg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O7kDy9fo+QVJRTBnowgujXivWn9jJ/fhtR8Vpd0lS0Fx1K9mayuh2YU6gn1+frT2H2GYeJ+Z1EiT50QSGHdM4CeaEdqFrd9cX+N8eB/o7/OOtr/PT/C7AA7nBGseL8QLYMspyf04AwjnMHOJy5sLag9EnhP9sVSOOhaE2YjE99Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=J1ZmXgt8; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="J1ZmXgt8" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-4671119c1c0so4035212b6e.1 for ; Tue, 17 Mar 2026 07:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773759574; x=1774364374; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZVSDrbvwel6uKQw3+Tq7/00i6DjO3Jc9G+zPvWgsFbI=; b=J1ZmXgt8H4wl8SfJ+xJGJrmJiwwTPLwtDCdwGS07Wax4bHYn3Tf2GiMdIFAhpWVLOv Yma+n25khK6OcV2/uf/Az3w+p7FlK/GkeRhkj0uMbTjnHmwVp7SGOcDKb4tAeW2NC5Fp XMitc+eWilL1hINGUEtk3o1bRl18vkNW078hTV8BoBhSJ3QWcm3qeVi/6K15zDfAbZ36 GeL8QyzLamXOR7PEbnK44GoHyZeypJRBVntw9NB6l5EHo9GyeSYwMo4aOKrw46cIt/Jw Hytt8CIlua3Z4JRT5UF4t5AsCha4NXZ9obOKi4TzO7huocqB1EhcD6fqEMjTCULwDzrY zOyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773759574; x=1774364374; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZVSDrbvwel6uKQw3+Tq7/00i6DjO3Jc9G+zPvWgsFbI=; b=Fj6NFTIUGLlFiZmVbYtv5TmMDcgjIugxPHP8bNoK7G8FWRN1VKm1cLOcfiyVHu1HPR gFRJEQeBmxPJuKVkGAQFxcf1OCNT45caill6/CvHtg+Dfpi5kjRXQtXBZx+eLDChdumv dOe+J3sfUerqYUXpMtzheuqltOiKBiNVbPmAuIS8Qfw5YU3MOuA0JOIICw5fbt+yx07V YD0BYxpxwbSM1IsOsQ4TpJSQO8euthoZMXAUdgxrXDSpskL1D/pYg8DCnTmLsuAQAqwM 8dQVHJdVG3NWcqGATG6kk7Zj6inNm623MVhJXZ26tTAIt6ONAXekz9xVP3pyXQk7E2nq 6SNw== X-Forwarded-Encrypted: i=1; AJvYcCVT4L/3O10GkaBCUKgWWhIInmA9li7wvPk74otsjqqec4lyoaX3a1k1fyuL43vdqJZxQz18NPow4iMJSm4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyh94RG4+lCH15n8f/DfgaYFqijq7qW/0clH2UGwjx9HtC+SpSd vTqGAIWim2uaKOw3VlI9PvAE78y6bqZ8TrWZoYpXVS4J40HllHwtjOzPpY/vYDlRZ2iis5gJgfV Ow+AC X-Gm-Gg: ATEYQzzwpF/VmXMJcJ4gq8X2xaGlwkom//kN6MEgjhMtb6gCVvI5nWxO/PBowoDIBjg FAuJT+x1Le4K5ls5EJaIvlwcF4d8GsS5g1P/NWIbvdets7ibCPhvcUEsdD0VYUY40At2+HqRSIe AKsLpHBCPJt3gQKpMjwvdz30+9syRtUabvi6fJs36spGM7mZ4th8GYRLEfLyeYZ158VI7j6uC+5 uDntQR4S8LML7tOMLQqbAc5d0fEo4r6bLUiTZZpkwRYAMXTvn8kChkPlrsSatiPS8Em8awXoJel y9hSEz+XDD4C08SQdpR0nxqDNZDVqX4h4az5g4ceDYl6adK+mdphHjC29LMQCI4MaxLgGn9BY+V 2jFfmXc3q4xhaVHzZufrJ8OIlmwIJCNvevLdtvJhDhhCx6dHf0NOHNrQ7IvV8UjCPEsccSmIWNi a0UNwpXfz5V9js899r5PtZ28sFFQUgozYiZ3ATiNKeA4JHf7SoZ/HYodjRMLu8bHSqmEt19+Q= X-Received: by 2002:a05:6808:179a:b0:467:3f4:9077 with SMTP id 5614622812f47-4675752d2ebmr9803196b6e.51.1773759574496; Tue, 17 Mar 2026 07:59:34 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:6995:28aa:eeda:102? ([2600:8803:e7e4:500:6995:28aa:eeda:102]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4177e5e94b4sm18335102fac.11.2026.03.17.07.59.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 07:59:34 -0700 (PDT) Message-ID: <968b4ae6-23cb-40fd-942c-66b82ae14544@baylibre.com> Date: Tue, 17 Mar 2026 09:59:33 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2] iio: iio-mux: use flexible array member To: Andy Shevchenko , Rosen Penev Cc: linux-iio@vger.kernel.org, Peter Rosin , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , open list References: <20260316232942.46641-1-rosenp@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/17/26 2:26 AM, Andy Shevchenko wrote: > On Mon, Mar 16, 2026 at 04:29:42PM -0700, Rosen Penev wrote: >> Make it clear that there's trailing data >> >> Removes a pointer from the struct. >> >> Use array_size for the sizeof calculations. Slightly cleaner. > > array_size() > sizeof() > > This commit message is poorly written. Please, consult with > https://chris.beams.io/git-commit on how to write better commit > messages. > > ... > >> struct mux { > >> struct iio_channel *parent; >> struct iio_chan_spec *chan; >> struct iio_chan_spec_ext_info *ext_info; >> - struct mux_child *child; >> u32 delay_us; >> + struct mux_child child[]; >> }; > > What's the point now to make it VLA? Again, why this and not the other one? I agree with Andy here. It doesn't make much sense to use a variable length array for one when there are other similar arrays in the same struct. > > ... > >> mux = iio_priv(indio_dev); >> - mux->child = (struct mux_child *)(mux + 1); >> mux->chan = (struct iio_chan_spec *)(mux->child + children); > > (This piece linked to the above comment.) >