From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from imap5.colo.codethink.co.uk (imap5.colo.codethink.co.uk [78.40.148.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0A4B305E10 for ; Fri, 3 Jul 2026 16:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.40.148.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783095847; cv=none; b=PRFpDrjPM31LWaAT0849LUjcOFzqCaDotlzavYxM1tXTFka2+wQoxi5P9AHfje4wO1GQk5mM1ApwmxmhbyGClDYUXtsi3id24/7rzJQ8w9LvGkbkS0Ktf/KL0cccOz+M/BlEF1lzVNmLVsL13Zfogyzi7uYnKEL2HkfvNX8RY64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783095847; c=relaxed/simple; bh=kHmmy2MS4drOEOcy1p3jC0lFnTlsH18xS6DdlWJu2hs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DaCrrmAGvtuFHohsmwJH4gPeCWiM3cpMz7wG+TrfJWRHfNiGtREqSM3XXLCUtmvI5LmcFi1jGzBygBJ3TlsmoxEn1H/A9Vmmzj9IBmY6Dpstox3oL1kTjNA3iUydCNKKXDfEvu4YPuYpp3tgbYgyDPHLZHATUJEFl/1tBKL73V8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk; spf=pass smtp.mailfrom=codethink.co.uk; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b=WKWVTjA1; arc=none smtp.client-ip=78.40.148.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b="WKWVTjA1" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codethink.co.uk; s=imap5-20230908; h=Sender:Content-Transfer-Encoding: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Reply-To; bh=bJF5AimFzn/vjuyllbCot1tOEiTcY9zfJPLE09CxB1k=; b=WKWVTjA1qyK0z/EV nYqifrOJMqF5TcMqQDW4p2f3Zg5k7ZAsuYayMVtY7X98ZlGCgeKFsSPt/NvxKoviP6d7zOs3yx5uM riwSOps4f+xnxYSGu1ZwemmHz8YnxkdDBtcoi0tKaSnzzuyLPsV7/x98pkcdd4Xid+wYBpt/Q0SSJ 9J1QU4HMEatqE0HOeQpQ76VboLbR0rajXfiPkGJRhLBDR0zYs1LfE5/kUQOVTG2ZzD+IAtXP+SJI4 Lzj7hF8z123wKQA5gogqDq/mB6x5cJCWHfQZVEBn/krHRrMK3/QvHKeRJXo86XoyIoYeivRlgTOHf Pw0p1Hx2oY4mutZi4Q==; Received: from [167.98.27.226] (helo=[10.35.6.194]) by imap5.colo.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1wfggE-00AfRf-Et; Fri, 03 Jul 2026 17:23:54 +0100 Message-ID: <968ee419-6eac-4b52-b193-40963d23ae42@codethink.co.uk> Date: Fri, 3 Jul 2026 17:23:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/imagination: make pvr_fw_trace_init_mask_ops static To: Alessio Belle Cc: "tzimmermann@suse.de" , "Matt.Coster@imgtec.com" , "simona@ffwll.ch" , "dri-devel@lists.freedesktop.org" , "airlied@gmail.com" , Frank Binns , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "linux-kernel@vger.kernel.org" References: <20260623105341.775693-1-ben.dooks@codethink.co.uk> <055465207ab6f86f0d12b73a592bbecd9768c8f6.camel@imgtec.com> <8114990b991bab4ad2b1ee97844db3c2556c05e7.camel@imgtec.com> Content-Language: en-GB From: Ben Dooks Organization: Codethink Limited. In-Reply-To: <8114990b991bab4ad2b1ee97844db3c2556c05e7.camel@imgtec.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: ben.dooks@codethink.co.uk On 01/07/2026 19:18, Alessio Belle wrote: > Hi Ben, > > On Mon, 2026-06-29 at 11:05 +0000, Alessio Belle wrote: >> On Tue, 2026-06-23 at 11:53 +0100, Ben Dooks wrote: >>> The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c >>> so make it static to avoid the following sparse warning: >>> >>> drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static? >>> >>> Signed-off-by: Ben Dooks >> >> Reviewed-by: Alessio Belle > > Actually, could you add a Fixes tag pointing at c6978643ea1c ("drm/imagination: > Validate fw trace group_mask")? You can then add the Reviewed-by tag as well for > last. > > Thanks, > Alessio ok, done -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html