From: Markus Elfring <Markus.Elfring@web.de>
To: Weigang He <geoffreyhe2@gmail.com>, Suman Anna <s-anna@ti.com>,
Jassi Brar <jassisinghbrar@gmail.com>
Cc: stable@vger.kernel.org, kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] mailbox: omap: fix reference count leak in omap_mbox_probe()
Date: Fri, 23 Jan 2026 12:15:48 +0100 [thread overview]
Message-ID: <969082ca-8af4-420e-992d-c6f4cc79f6c6@web.de> (raw)
In-Reply-To: <20260123035648.1441763-1-geoffreyhe2@gmail.com>
…
> 1. Using goto-based error handling to ensure of_node_put(child) is
> called on all error paths within the loop
> 2. Adding of_node_put(child) after the loop completes normally to
> release the last child node reference
How do you think about to increase the application of scope-based resource management
with another patch?
Regards,
Markus
prev parent reply other threads:[~2026-01-23 11:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 3:56 Weigang He
2026-01-23 11:15 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=969082ca-8af4-420e-992d-c6f4cc79f6c6@web.de \
--to=markus.elfring@web.de \
--cc=geoffreyhe2@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s-anna@ti.com \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®