From: Joel Fernandes <joelagnelf@nvidia.com>
To: Rosen Penev <rosenp@gmail.com>, dri-devel@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>,
Arun Pravin <arunpravin.paneerselvam@amd.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Dave Airlie <airlied@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpu/buddy: drop stale @p from gpu_buddy_print() kernel-doc
Date: Sun, 4 Oct 2026 20:59:35 -0400 [thread overview]
Message-ID: <969157ef-9ff6-469f-a900-9b8ea326ff9e@nvidia.com> (raw)
In-Reply-To: <20261004235255.547593-1-rosenp@gmail.com>
On 10/4/2026 7:52 PM, Rosen Penev wrote:
> gpu_buddy_print() lost its printer argument when the buddy allocator
> moved out of DRM and now prints with pr_info(), but the kernel-doc
> still describes @p:
>
> buddy.c:2153 Excess function parameter 'p' description in 'gpu_buddy_print'
>
> Remove the stale line.
>
> Fixes: ba110db8e1bc ("gpu: Move DRM buddy allocator one level up (part two)")
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/gpu/buddy.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/buddy.c b/drivers/gpu/buddy.c
> index 2f2aaadafe35..503f7d5934e4 100644
> --- a/drivers/gpu/buddy.c
> +++ b/drivers/gpu/buddy.c
> @@ -2148,7 +2148,6 @@ EXPORT_SYMBOL(gpu_buddy_block_print);
> * gpu_buddy_print - print allocator state
> *
> * @mm: GPU buddy manager
> - * @p: GPU printer to use
> */
> void gpu_buddy_print(struct gpu_buddy *mm)
> {
Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>
prev parent reply other threads:[~2026-10-05 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 23:52 Rosen Penev
2026-10-05 0:59 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=969157ef-9ff6-469f-a900-9b8ea326ff9e@nvidia.com \
--to=joelagnelf@nvidia.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=arunpravin.paneerselvam@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=rosenp@gmail.com \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®