From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756189AbcIFKfg (ORCPT ); Tue, 6 Sep 2016 06:35:36 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:15978 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338AbcIFKfd (ORCPT ); Tue, 6 Sep 2016 06:35:33 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 06 Sep 2016 03:30:39 -0700 Subject: Re: [PATCH v2 3/6] dt/bindings: Add bindings for Tegra GMI controller To: Mirza Krak , Rob Herring References: <1472045838-22628-1-git-send-email-mirza.krak@gmail.com> <1472045838-22628-4-git-send-email-mirza.krak@gmail.com> <20160830170636.GA8741@rob-hp-laptop> CC: Stephen Warren , Thierry Reding , Alexandre Courbot , , , Prashant Gaikwad , Michael Turquette , , , , , linux-kernel , , From: Jon Hunter Message-ID: <96929bd4-9fca-634f-d8a4-62ad26abdea3@nvidia.com> Date: Tue, 6 Sep 2016 11:35:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.21.132.106] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/08/16 12:22, Mirza Krak wrote: ... > Taking your comments in to account I end up with this: > > gmi@70090000 { > compatible = "nvidia,tegra20-gmi"; > reg = <0x70009000 0x1000>; > #address-cells = <2>; Does this need to be 2? Seems simpler if this is 1. Cheers Jon -- nvpublic