mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: jejb@linux.ibm.com, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org,
	martin.petersen@oracle.com, stern@rowland.harvard.edu
Subject: Re: [PATCH v3 2/4] scsi: devinfo: add new flag BLIST_MEDIA_CHANGE
Date: Sun, 28 Mar 2021 09:54:22 -0700	[thread overview]
Message-ID: <96931408-2613-4de3-e220-fd63f02b6095@acm.org> (raw)
In-Reply-To: <20210328102531.1114535-3-martin.kepplinger@puri.sm>

On 3/28/21 3:25 AM, Martin Kepplinger wrote:
> +/* Ignore the next media change event */
> +#define BLIST_MEDIA_CHANGE	((__force blist_flags_t)(1ULL << 11))

That comment is not descriptive enough. Consider to change it into
something like the following: "ignore one MEDIA CHANGE unit attention
after resuming from runtime suspend".

Thanks,

Bart.

  reply	other threads:[~2021-03-28 16:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-28 10:25 [PATCH v3 0/4] scsi: add runtime PM workaround for SD cardreaders Martin Kepplinger
2021-03-28 10:25 ` [PATCH v3 1/4] scsi: add expecting_media_change flag to error path Martin Kepplinger
2021-03-28 16:53   ` Bart Van Assche
2021-03-29  8:05     ` Martin Kepplinger
2021-03-28 10:25 ` [PATCH v3 2/4] scsi: devinfo: add new flag BLIST_MEDIA_CHANGE Martin Kepplinger
2021-03-28 16:54   ` Bart Van Assche [this message]
2021-03-28 10:25 ` [PATCH v3 3/4] scsi: sd: use expecting_media_change for BLIST_MEDIA_CHANGE devices Martin Kepplinger
2021-03-28 16:46   ` Bart Van Assche
2021-03-28 10:25 ` [PATCH v3 4/4] scsi: devinfo: add BLIST_MEDIA_CHANGE for Ultra HS-SD/MMC usb cardreaders Martin Kepplinger
2021-03-28 14:58 ` [PATCH v3 0/4] scsi: add runtime PM workaround for SD cardreaders Alan Stern
2021-03-28 15:16   ` Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96931408-2613-4de3-e220-fd63f02b6095@acm.org \
    --to=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=martin.petersen@oracle.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®