From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF3EA3E2ACE for ; Wed, 27 May 2026 08:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779871874; cv=none; b=qCWtSNiZIOYEM7PiTIOJsp/79hcRhlz9al8M8SU8GxYFmtUfn3amMxSZ4bC+CNm7mI52Pd3/Np4Lg7qgV3/EskflKQ0cNQpmW4nfPapzEenWFEg3whdItIwma9nGVh7jmokFpDxbXzKDFBDu1NIJ4JzrTGzPZubdyGcLc0l+P+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779871874; c=relaxed/simple; bh=DFJoUVD3KvyymoOkoSNQAVLhRnYQDEGBHGGZx7nO70o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EKz0mRcWGiZTXl7r+YQhJR8xwVZJ93KKdoJLZxiaJNyABnsdBWGsOvBFHeQcwwsCgBvNwJyFEA4jjP5K4sHGNXJUgX9vvOXyGo4fJ15ebwZ+a3Kdp48HI0y3xGqwi1qExY4HF8hHG67/kCDf6vCSkTI+bV2Cx8rh24hps9NVlaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iS6p1WY/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JDirJV3R; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iS6p1WY/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JDirJV3R" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64R8mV8f879338 for ; Wed, 27 May 2026 08:51:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /6hNas6apydJkTdrJtwj+iHqEC9GL8SPaeohHHAAp3w=; b=iS6p1WY/yLTgswAO 8kWHVQSv0t9Roku2LWMl/84BJ5Sqv5pfrfrBSh+ovc3y19nLMBaTKCexsYkGCcAy YOs7bN9t6X9zclCEJ3ZW6Jn6Quqb+U+84cZM88yvSG70/1UIXF6cVF3PKg43PigB /NjSKa9zqzEsYIZ/jbhl7Sa2axDwlsVZ1EapXYwKtLvxivHIa6qYgoKbYiPJFR7s zfRIp+FuuOoIFcL3VSTJVtSU+ub4xsPa3dC4Cje77AkRU9/lWD+3AKpM7aT0T35F F7KHP1SUBtuMelQkAAuPgIoKr68znGMcwWYhbe7t7Zo9+OBbGLc8sQeqkdatBNXx JyASLA== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4edvvqr553-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 27 May 2026 08:51:11 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-837c4eb3bdfso6922395b3a.2 for ; Wed, 27 May 2026 01:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779871871; x=1780476671; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/6hNas6apydJkTdrJtwj+iHqEC9GL8SPaeohHHAAp3w=; b=JDirJV3RAK++piRvBQUBCBaaHoo/fAE7s+2YqNGXKtMiLpi7lfYfclWVIYWisTX6fN mFSVn5g5+KMYsMY45wV5mSxepHSRwRz1uTdTuhpgoGs/itz5EtgahH+0lesuwWuvlfbJ EMBFfOr89keS+YyLCf8p1IT86swh0ICmXkcFAk66a88p3OLj7++kzvBOzUlsX7tzLMva jHLkldax5F3HJjl2za4dbZz9xVY6OoRXgGStshtuy5ghFf06l8qro+96jSkuqXqsEHsL /9NPunbhX5c+RcLwFqMFgCedcEii6n+xSMxgeS80pIN7B1RI47doZwklDfQ57sj34yCp JiBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779871871; x=1780476671; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/6hNas6apydJkTdrJtwj+iHqEC9GL8SPaeohHHAAp3w=; b=HILu6Mr6r2k1TH+1n+YzAuF6RDQ0KzBWO1VCwoilgEOFmzOyORePSu6pu4/Bdyt/Qo xZhg00BIJZG6uRIFHcuzSpWDvPn0YLLWmJgYl/IpmOmlqZNviJvJmxrWFQCAy4z6IO5Z kTjwe6B3+g8gEHDNq2aKMo8mxNwviTvE6Xm+4ojWXPnLvfJlgX2eBQfAqxBDcE2Gw5au lyYnuN3kmVo8sTCexqge8pDbINeygNKD1RVt8oHQ4g8iTbVAQAZFMhhFMZJvnMO2WGBD o/RkPqgVkjjfb8+nq/87BmAMc6oxbPSIv4XM/8ZZ9NavzXFUdLLfSLl8y4tzEyCWfL/J IsQw== X-Forwarded-Encrypted: i=1; AFNElJ8JlOKJiYKK+UKU4LdG2yN84jEKRW3q1rOtT/aQ7invqd+Zs2HEw+WzYdvdM5upEdn8NgxEtjckzRn1kN4=@vger.kernel.org X-Gm-Message-State: AOJu0YzBpUaBAzlpaZqSNKEZjYr6kbVVJ1ikXqXgPFlaC/LYM5De8LfF B9N/pVFNL9ErcXQh565GQU2FZpUl1vzecEaUciKJ7zW1KClIuWWF/m62R3+zPBf6Eix8Hy1vKtI FrRtRidN6J4bxj1n98wi2IxSfTJ6VaPU6BFYk9BGOxMHBpbVBLFDH3XKkTGQK1QdEnlI= X-Gm-Gg: Acq92OF8HD4c5cZJRAKyCF6k+f88cZbBe3q7MQ4fiLreX+4gRtZvprkCsZ7dTJJyf5P WxIa5ax81k/ZdpfoIhddVrGy5eCtt5q55kUTx1WjFDa5HQCB32RwkFl+WXGUBJsp66co0ovr702 JVXd/rSL86S8vUa0uaGOccGO+LeaaFp+VzCRFOQkUe37EsOWAb8iVjS1PQCM/d0cI6ID4we6b3I WevgtDYSokZd3jmfPtYCCjjwqXtQAcRORtROsvnaxUj765Lr7W8puQShyAywqN7YzncirNv9l5p aKi9Q9SeHeKBPPPANEqpGu64+dpY9ocWafBKaigg7LO4v+oE1WKGg/Uht1AiJYevfuWUPtCwyjB LdXt1Vfm7Bqlf6sdcdxSSeAGMGpeqPHyXmoma51ff9wU/zR1SKSev33Rll3++Gwfud97juyUnda Mhj6sseqse+YPcjojJ0BeiRw== X-Received: by 2002:a05:6a00:8c04:b0:835:cc47:6fe3 with SMTP id d2e1a72fcca58-8415f3b0825mr23559362b3a.45.1779871870744; Wed, 27 May 2026 01:51:10 -0700 (PDT) X-Received: by 2002:a05:6a00:8c04:b0:835:cc47:6fe3 with SMTP id d2e1a72fcca58-8415f3b0825mr23559329b3a.45.1779871870245; Wed, 27 May 2026 01:51:10 -0700 (PDT) Received: from [10.133.33.247] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841d6ebb97bsm1659411b3a.23.2026.05.27.01.51.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2026 01:51:09 -0700 (PDT) Message-ID: <96962564-ff25-4d81-a605-3d9c05fa000a@oss.qualcomm.com> Date: Wed, 27 May 2026 16:51:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: ufs: Document static TX Equalization settings properties To: Manivannan Sadhasivam Cc: bvanassche@acm.org, beanhuo@micron.com, peter.wang@mediatek.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, Alim Akhtar , Avri Altman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ram Kumar Dwivedi , Zhaoming Luo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20260523134711.323425-1-can.guo@oss.qualcomm.com> <20260523134711.323425-2-can.guo@oss.qualcomm.com> Content-Language: en-US From: Can Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI3MDA4NCBTYWx0ZWRfX1pPgnlXb/Hif kbLxAOXEj6lsMNUA+Zn3qUqxW9vwjGylUeornCiZlOpPz3KROEEhMLKy9zXawzaC2ZsKpmYEDU9 zxhPoi/DMgn3wfruUwM6yjuf6ynSbrKawKfSHYuFxeBeHxJC1YZ+z5Kggmv9RZZn/lXtSfwEvj0 apF6/0y1wvXthFyoQ3Fg6sLCe8Mi9Xh5ZnoNNqT74qp7bUNhVDkxXctMgYg/Zhf1L+YRfd+hCrR Zz5A6znZsZ95uJqqwJLa8jLHLZjK2k0a9QEnGQOCZ1fEwRF7eIKajGiOnCCZSrmrxcoeUkmjKWD WIshxhHtKtk93lTeaKSay8bqM1EoJ2NH5BOzAB0G2I8rks3u1SVzXQRWjMlmj/TLh1HQoKDOlcD HBVUv3VdUOhVOwxftbrtwyJS+SkiEJc2zoT3Es58FTGUd6bSdc9La1ElqMbgkVHeVXigYaJ+ouE hRElqNkbhocQ5ENfoLA== X-Proofpoint-GUID: xdaYolAvr_5_ByHlaqx2_0Qb91ApJ0cn X-Proofpoint-ORIG-GUID: xdaYolAvr_5_ByHlaqx2_0Qb91ApJ0cn X-Authority-Analysis: v=2.4 cv=fLMJG5ae c=1 sm=1 tr=0 ts=6a16b07f cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=YG64nluAAAAA:20 a=eDkNqlp1enX9kxdETvUA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-27_01,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 suspectscore=0 spamscore=0 impostorscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605270084 Hi Mani, On 5/23/2026 10:14 PM, Manivannan Sadhasivam wrote: > On Sat, May 23, 2026 at 06:47:10AM -0700, Can Guo wrote: >> UFS v5.0/UFSHCI v5.0 add HS-G6 support (46.6 Gbps/lane) via UniPro v3.0 >> and M-PHY v6.0. In these specs, TX Equalization is defined for all High >> Speed Gears (not only HS-G6) to compensate channel loss and improve signal >> integrity at high speed operation. >> >> For HS-G6, M-PHY uses PAM4 1b1b line coding, Pre-Coding may also be >> required depending on channel characteristics. >> >> Add vendor-neutral DT patternProperties: >> txeq-settings-g[1-6] >> >> Each property is a uint32 array of per-lane tuples: >> (PreShoot, DeEmphasis, PrecodeEn) >> > I don't think combining all EQ settings (PreShoot, DeEmphasis, PrecodeEn) in a > single property as opaque tuples is the right approach. These are three > semantically distinct parameters with independent value ranges. So packing > them into a uint32 array makes validation impossible in the schema. > > AFACIS, PrecodeEn is applicable only to HS-G6 (PAM4), but the proposed > patternProperties forces it into G1-G5 tuples as well, which is semantically > wrong. Point taken for the PrecodeEn. > > PCIe binding defines one property per data rate for EQ presets: > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/pci/pci-bus-common.yaml#L193 > > Similarly, UFS should define one property per gear per (like, txeq-preshoot-g6, > txeq-deemphasis-g6, txeq-precode-enable-g6,...) rather than clubbing everything > into opaque tuples. Thanks for the suggestion. I will go with below approach: txeq-preshoot-g6 = ; txeq-deemphasis-g6 = ; txeq-precode-en-g6 = ; Thanks, Can Guo. > > - Mani >