From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F95C47404 for ; Fri, 4 Oct 2019 15:00:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62EC72133F for ; Fri, 4 Oct 2019 15:00:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389627AbfJDPAC (ORCPT ); Fri, 4 Oct 2019 11:00:02 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3203 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389113AbfJDPAC (ORCPT ); Fri, 4 Oct 2019 11:00:02 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 0E19229BBAB67237FAAD; Fri, 4 Oct 2019 22:59:58 +0800 (CST) Received: from [127.0.0.1] (10.202.227.179) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Fri, 4 Oct 2019 22:59:51 +0800 Subject: Re: [PATCH 0/4] HiSilicon hip08 uncore PMU events additions To: Arnaldo Carvalho de Melo References: <1567612484-195727-1-git-send-email-john.garry@huawei.com> <27e693fd-124e-1aa8-3b8a-62301a5a1d10@huawei.com> <20191004143658.GA17687@kernel.org> <20191004143835.GB17687@kernel.org> CC: , , , , , , , , , , James Clark From: John Garry Message-ID: <969729ce-6246-6fa7-45c9-3dd9cb07059d@huawei.com> Date: Fri, 4 Oct 2019 15:59:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20191004143835.GB17687@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.179] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/2019 15:38, Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 04, 2019 at 11:36:58AM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, Oct 04, 2019 at 03:30:07PM +0100, John Garry escreveu: >>> On 04/09/2019 16:54, John Garry wrote: >>>> This patchset adds some missing uncore PMU events for the hip08 arm64 >>>> platform. >>>> >>>> The missing events were originally mentioned in >>>> https://lkml.org/lkml/2019/6/14/645, when upstreaming the JSONs initially. >>>> >>>> It also includes a fix for a DDRC eventname. >>> >>> Hi guys, >>> >>> Could I get these JSON updates picked up please? Maybe they were missed >>> earlier. Let me know if I should re-post. >> >> Looking at them now. > > It would be really good if somehow we managed to have someone from the > ARM community to check and provide a Reviewed-by for those, i.e. someone > else than the poster to look at it and check that its ok, would that be > possible? Hi Arnaldo, For this specific case, I'm not sure how much traction or value there would be since we're just adding some missing events for custom IP. But I do agree that more review of JSONs from the community is required - as I brought up here regarding a recent addition: https://lore.kernel.org/lkml/749a0b8e-2bfd-28f6-b34d-dc72ef3d3a74@huawei.com/ Can we enforce that at least linux-arm-kernel@lists.infradead.org and/or get_maintainer.pl results is cc'ed on anything ARM specific as a start? Cheers, John > > - Arnaldo > >> - Arnaldo >> >>> Thanks in advance, >>> John >>> >>>> >>>> John Garry (4): >>>> perf jevents: Fix Hisi hip08 DDRC PMU eventname >>>> perf jevents: Add some missing events for Hisi hip08 DDRC PMU >>>> perf jevents: Add some missing events for Hisi hip08 L3C PMU >>>> perf jevents: Add some missing events for Hisi hip08 HHA PMU >>>> >>>> .../arm64/hisilicon/hip08/uncore-ddrc.json | 16 +++++- >>>> .../arm64/hisilicon/hip08/uncore-hha.json | 23 +++++++- >>>> .../arm64/hisilicon/hip08/uncore-l3c.json | 56 +++++++++++++++++++ >>>> 3 files changed, 93 insertions(+), 2 deletions(-) >>>> >>> >> >> -- >> >> - Arnaldo >